Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Make sure the commit hash is always of the same length in impl_version #11404

Merged
paritytech-processbot merged 4 commits into from
May 16, 2022
Merged

Make sure the commit hash is always of the same length in impl_version #11404

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6a1417d
Make sure the commit hash is always of the same length in `impl_version`
koute May 12, 2022
e194a06
Add a comment regarding the length of the commit hash
koute May 12, 2022
dcec22f
Merge remote-tracking branch 'origin/master' into master_version_comm…
koute May 13, 2022
7f28038
Merge remote-tracking branch 'origin/master' into master_version_comm…
koute May 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion utils/build-script-utils/src/version.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,10 @@ pub fn generate_cargo_keys() {
let commit = if let Ok(hash) = std::env::var("SUBSTRATE_CLI_GIT_COMMIT_HASH") {
Cow::from(hash.trim().to_owned())
} else {
match Command::new("git").args(&["rev-parse", "--short", "HEAD"]).output() {
// We deliberately set the length here to `11` to ensure that
// the emitted hash is always of the same length; otherwise
// it can (and will!) vary between different build environments.
match Command::new("git").args(&["rev-parse", "--short=11", "HEAD"]).output() {
Ok(o) if o.status.success() => {
let sha = String::from_utf8_lossy(&o.stdout).trim().to_owned();
Cow::from(sha)
Expand Down