Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

trie: Optimize keys function #11457

Merged
bkchr merged 2 commits into from
May 18, 2022
Merged

trie: Optimize keys function #11457

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9199915
trie: Optimize `keys` function
bkchr May 18, 2022
1089011
Add a test
bkchr May 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 3 additions & 16 deletions primitives/state-machine/src/trie_backend_essence.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,22 +453,9 @@ where

/// Returns all keys that start with the given `prefix`.
pub fn keys(&self, prefix: &[u8]) -> Vec<StorageKey> {
let collect_all = || -> sp_std::result::Result<_, Box<TrieError<H::Out>>> {
let trie = TrieDB::<H>::new(self, &self.root)?;
let mut v = Vec::new();
for x in trie.iter()? {
let (key, _) = x?;
if key.starts_with(prefix) {
v.push(key.to_vec());
}
}

Ok(v)
};

collect_all()
.map_err(|e| debug!(target: "trie", "Error extracting trie keys: {}", e))
.unwrap_or_default()
let mut keys = Vec::new();
self.for_keys_with_prefix(prefix, |k| keys.push(k.to_vec()));
keys
}

/// Return the storage root after applying the given `delta`.
Expand Down