Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Conversation

@ggwpez
Copy link
Member

@ggwpez ggwpez commented May 23, 2022

The doc check in #11493 fails since it treats [NS] as link 🤦‍♂️

Fixed by not using abbreviations.

bkchr and others added 6 commits May 21, 2022 07:24
* InMemoryBackend: Make it generic over the key hasher

* Update primitives/state-machine/src/in_memory_backend.rs

Co-authored-by: cheme <[email protected]>

* Update primitives/state-machine/src/in_memory_backend.rs

Co-authored-by: cheme <[email protected]>

* FMT

Co-authored-by: cheme <[email protected]>
* Unify rpc api and implementation name

Signed-off-by: koushiro <[email protected]>

* MauanlSeal ==> ManualSealRpc

Signed-off-by: koushiro <[email protected]>

* Remove extra Rpc naming in the structs

Signed-off-by: koushiro <[email protected]>

* Update doc

Signed-off-by: koushiro <[email protected]>

* fix merge

Co-authored-by: Shawn Tabrizi <[email protected]>
…few bugs (#11461)

* cli: fix RPC CLI nits

* remove needless lines

* cargo fmt

* Update client/service/src/lib.rs

Co-authored-by: James Wilson <[email protected]>

Co-authored-by: James Wilson <[email protected]>
If `--validator` is passed we also listen on this address and as `--dev` is a shortcut for multiple
CLI args, including `--validator`, we should make it consistent.
* enable signed migrations in benchmarks

* T instead of Test

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

* Remove 'mut'

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

Co-authored-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
@ggwpez ggwpez added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit. labels May 23, 2022
@ggwpez ggwpez changed the title Fix comment for cargo doc check Fix weight templates for cargo doc check May 23, 2022
@ggwpez ggwpez added the A0-please_review Pull request needs code review. label May 23, 2022
@shawntabrizi shawntabrizi changed the base branch from master to shawntabrizi-bench-script May 23, 2022 13:57
@shawntabrizi
Copy link
Member

superseded by fb03b54

@shawntabrizi shawntabrizi deleted the oty-ns-weight-templates branch May 23, 2022 13:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A0-please_review Pull request needs code review. A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit.

Projects

Development

Successfully merging this pull request may close these issues.

6 participants