Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Replace T::AccountId with <T::Lookup as StaticLookup>::Source #11670

Merged
paritytech-processbot merged 23 commits into from
Aug 18, 2022
Merged

Replace T::AccountId with <T::Lookup as StaticLookup>::Source #11670

paritytech-processbot merged 23 commits into from
Aug 18, 2022

Conversation

@Doordashcon
Copy link
Contributor

@Doordashcon Doordashcon commented Jun 15, 2022 •
edited
Loading

Fixes #6042

polkadot address: 12zsKEDVcHpKEWb99iFt3xrTCQQXZMu477nJQsTBBrof5k2h

@kianenigma kianenigma changed the title Ddc cdc t1 Replace T::AccountId with <T::Lookup as StaticLookup>::Source Jun 15, 2022
@Doordashcon Doordashcon marked this pull request as ready for review June 17, 2022 15:56
@Doordashcon
Copy link
Contributor Author

Doordashcon commented Jun 26, 2022

cc @kianenigma

kianenigma
kianenigma reviewed Jul 1, 2022
View reviewed changes
Copy link
Contributor

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, I wonder if anyone has an idea to reduce the clutter a bit?

@Doordashcon
Copy link
Contributor Author

Doordashcon commented Jul 5, 2022

Overall looks good, I wonder if anyone has an idea to reduce the clutter a bit?

cc @gilescope

@gilescope
Copy link
Contributor

gilescope commented Jul 6, 2022

Could be a good case for using type alias? Maybe called AccoundIdLookup or some such?

@Doordashcon
Copy link
Contributor Author

Doordashcon commented Jul 7, 2022

Could be a good case for using type alias? Maybe called AccoundIdLookup or some such?

Sounds good, If this works @kianenigma I'll go right ahead and implement it.

@kianenigma
Copy link
Contributor

kianenigma commented Jul 7, 2022

Yeah perhaps AccountIdLookupOf<T>.

@Doordashcon Doordashcon requested a review from athei as a code owner July 12, 2022 13:21
@Doordashcon Doordashcon requested a review from kianenigma July 12, 2022 22:01
@kianenigma kianenigma added A0-please_review Pull request needs code review. B7-runtimenoteworthy C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Jul 13, 2022
kianenigma
kianenigma approved these changes Jul 13, 2022
View reviewed changes
Copy link
Contributor

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to see this finally closed.

@kianenigma
Copy link
Contributor

kianenigma commented Jul 13, 2022

CI and git conflicts need to go away though.

@Doordashcon
Copy link
Contributor Author

Doordashcon commented Jul 21, 2022

@athei please review

@xlc
Copy link
Contributor

xlc commented Aug 4, 2022

This needs label E6-transactionversion

@Doordashcon
Copy link
Contributor Author

Doordashcon commented Aug 13, 2022

Does this PR need any more attention apart from the conflicts?

ggwpez
ggwpez reviewed Aug 15, 2022
View reviewed changes
Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Just one case where pallet-unique::set_price still uses <T::Lookup as StaticLookup>::Source.

@Doordashcon Doordashcon requested a review from ggwpez August 15, 2022 22:16
@ggwpez
Resolve master conflicts
ae49179 
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
@ggwpez
Copy link
Member

ggwpez commented Aug 18, 2022

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 22b678f into paritytech:master Aug 18, 2022
@shawntabrizi
Copy link
Member

shawntabrizi commented Aug 18, 2022

/tip medium

@substrate-tip-bot
Copy link

substrate-tip-bot bot commented Aug 18, 2022

@shawntabrizi A medium tip was successfully submitted for Doordashcon (12zsKEDVcHpKEWb99iFt3xrTCQQXZMu477nJQsTBBrof5k2h on polkadot).

https://polkadot.js.org/apps/?rpc=wss%3A%2F%2Frpc.polkadot.io#/treasury/tips

@Doordashcon
Copy link
Contributor Author

Doordashcon commented Aug 18, 2022

Thanks for the tip!

@sacha-l sacha-l mentioned this pull request Sep 7, 2022
Open
2 tasks
@librelois librelois mentioned this pull request Sep 15, 2022
Closed
2 tasks
@wischli wischli mentioned this pull request Sep 21, 2022
Merged
6 tasks
@notlesh notlesh mentioned this pull request Sep 27, 2022
Merged
13 tasks
@Doordashcon Doordashcon mentioned this pull request Sep 29, 2022
Merged
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
@Doordashcon @ggwpez @ark0f
Replace T::AccountId with <T::Lookup as StaticLookup>::Source (pa…
23dbbc8 
…ritytech#11670)

* initial

* update

* update

* update

* cargo fmt

* update

* update benchmarks

* AccountIdLookupOf<T>

* cargo fmt

* fix conflits

* cargo fmt

* update

Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: Oliver Tale-Yazdi <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@athei athei athei approved these changes

@kianenigma kianenigma kianenigma approved these changes

@ggwpez ggwpez ggwpez approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D2-breaksapi D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

T::AccountId used over <T::Lookup as StaticLookup>::Source in dispatchable calls

7 participants

@Doordashcon @gilescope @kianenigma @xlc @ggwpez @shawntabrizi @athei