update test comments

frame/alliance/src/benchmarking.rs

@@ -633,6 +633,8 @@ benchmarks_instance_pallet! {
 			voting_members: c,
 			ally_members: m,
 		};
+		let mut old_fellows: Vec<T::AccountId> = Vec::new();
+		let mut old_allies: Vec<T::AccountId> = Vec::new();
 
 		let mut cc = c;
 		if (m > 0 && c == 0) || (p > 0 && c == 0) {
@@ -643,8 +645,8 @@ benchmarks_instance_pallet! {
 			// one voting member required to create proposal.
 			cc = 1;
 		}
-		let mut old_fellows: Vec<T::AccountId> = Vec::new();
-		let mut old_allies: Vec<T::AccountId> = Vec::new();
+
+		// setting the Alliance to disband on the benchmark call
 		if cc > 0 {
 			old_fellows = (0..cc).map(fellow::<T, I>).collect::<Vec<_>>();
 			old_allies = (0..m).map(ally::<T, I>).collect::<Vec<_>>();
@@ -687,11 +689,11 @@ benchmarks_instance_pallet! {
 			assert_eq!(Alliance::<T, I>::ally_members_count(), m);
 		}
 
-		// Add previous proposals.
+		// adding proposals to veto on the Alliance reset
 		for i in 0..p {
 			let threshold = cc;
 			let bytes_in_storage = i + size_of::<Cid>() as u32 + 32;
-			// Proposals should be different so that different proposal hashes are generated
+			// proposals should be different so that different proposal hashes are generated
 			let proposal: T::Proposal =
 				AllianceCall::<T, I>::set_rule { rule: rule(vec![i as u8; i as usize]) }.into();
 			Alliance::<T, I>::propose(

frame/alliance/src/tests.rs

@@ -39,8 +39,8 @@ fn force_set_members_works() {
 		assert_ok!(Alliance::propose(Origin::signed(1), 3, Box::new(k_proposal), k_proposal_len));
 		let mut proposals = vec![hash, k_hash];
 
+		// give a retirement notice to check later a retiring member not removed
 		assert_ok!(Alliance::give_retirement_notice(Origin::signed(2)));
-
 		assert!(Alliance::is_member_of(&2, MemberRole::Retiring));
 
 		// join alliance and reserve funds
@@ -86,6 +86,8 @@ fn force_set_members_works() {
 			),
 			Error::<Test, ()>::AllianceAlreadyInitialized,
 		);
+
+		// wrong witness data checks
 		assert_noop!(
 			Alliance::force_set_members(
 				Origin::root(),
@@ -117,6 +119,7 @@ fn force_set_members_works() {
 			Error::<Test, ()>::BadWitness,
 		);
 
+		// founders missing, other members given
 		assert_noop!(
 			Alliance::force_set_members(
 				Origin::root(),
@@ -139,8 +142,10 @@ fn force_set_members_works() {
 
 		// assert new set of voting members
 		assert_eq!(Alliance::votable_members_sorted(), vec![4, 5, 8]);
-		// assert new members
+		// assert new ally member
 		assert!(Alliance::is_ally(&2));
+		// assert a retiring member from previous Alliance not removed
+		assert!(Alliance::is_member_of(&2, MemberRole::Retiring));
 		// assert old alliance disband.
 		assert!(!Alliance::is_member(&1));
 		assert!(!Alliance::is_member(&3));
@@ -151,6 +156,7 @@ fn force_set_members_works() {
 		assert_eq!(<Test as Config>::ProposalProvider::proposals(), vec![]);
 		assert_eq!(<Test as Config>::ProposalProvider::proposals_count(), 0);
 
+		// assert events
 		proposals.sort();
 		assert_prev_event(mock::Event::Alliance(crate::Event::AllianceDisband {
 			members: vec![1, 3, 9],