client/beefy: add issue references for future work todos

client/beefy/src/communication/peers.rs

@@ -18,6 +18,9 @@
 
 //! Logic for keeping track of BEEFY peers.
 
+// TODO (issue #12296): replace this naive peer tracking with generic one that infers data
+// from multiple network protocols.
+
 use sc_network::PeerId;
 use sp_runtime::traits::{Block, NumberFor, Zero};
 use std::collections::{HashMap, VecDeque};

client/beefy/src/communication/request_response/incoming_requests_handler.rs

@@ -147,7 +147,7 @@ where
 
 	// Sends back justification response if justification found in client backend.
 	async fn handle_request(&self, request: IncomingRequest<B>) -> Result<(), Error> {
-		// TODO: validate `request.begin` and change peer reputation for invalid requests.
+		// TODO (issue #12293): validate `request` and change peer reputation for invalid requests.
 
 		let maybe_encoded_proof = self
 			.client
@@ -182,7 +182,7 @@ where
 					)
 				},
 				Err(e) => {
-					// TODO: handle reputation changes here
+					// TODO (issue #12293): apply reputation changes here based on error type.
 					debug!(
 						target: "beefy::sync",
 						"🥩 Failed to handle BEEFY justification request from {:?}: {}", peer, e,

client/beefy/src/communication/request_response/outgoing_requests_engine.rs

@@ -102,10 +102,12 @@ where
 	}
 
 	fn reset_peers_cache_for_block(&mut self, block: NumberFor<B>) {
+		// TODO (issue #12296): replace peer selection with generic one that involves all protocols.
 		self.peers_cache = self.live_peers.lock().at_least_at_block(block);
 	}
 
-	pub fn try_next_peer(&mut self) -> Option<PeerId> {
+	fn try_next_peer(&mut self) -> Option<PeerId> {
+		// TODO (issue #12296): replace peer selection with generic one that involves all protocols.
 		let live = self.live_peers.lock();
 		while let Some(peer) = self.peers_cache.pop_front() {
 			if live.contains(&peer) {