This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Move Get and bounded types to sp-core #12203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KiChjang
added
A0-please_review
KiChjang
requested review from
bkchr,
ggwpez,
kianenigma,
sam0x17 and
shawntabrizi
kianenigma
approved these changes
Sep 7, 2022
Member
|
Can you be more specific on why this is needed? Where are we having circular depedencies? |
shawntabrizi
approved these changes
Sep 7, 2022
Member
shawntabrizi
left a comment
shawntabrizi
left a comment
There was a problem hiding this comment.
would like basti's question to be answered, but it makes sense to me
Contributor
Author
|
@bkchr I'm in the middle of creating a new crate called |
bkchr
approved these changes
Sep 7, 2022
Contributor
Author
|
bot merge |
|
Waiting for commit status. |
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* Move Get and bounded types to sp-core * Fixes * cargo fmt * Fixes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the
Gettraits, bounded types and associated macros tosp-corefromsp-runtime.The motivation here is a recognition that these types and traits don't really require a notion of the runtime, and are simply plain Rust new types that can be generally applied everywhere, which then makes it easier for new crates to resolve circular dependency issues as they do not necessarily need to depend on
sp-runtime, but rather something even more basic and primitive than it.