This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Use --locked for Cargo in CI everywhere
#12270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcny
added
A0-please_review
bkchr
approved these changes
Sep 14, 2022
sergejparity
approved these changes
Sep 15, 2022
altaua
approved these changes
Sep 15, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain situations exist where depending on a lock file could be a good idea, especially for the CI. This could prevent cases like this (reported on Matrix by @ggwpez) from happening.
This PR adds
--lockedflag to all Cargo runs in the CI, making Cargo always respect existingCargo.lockfiles.