Update frame/executive/src/lib.rs

Co-authored-by: Keith Yeung <[email protected]>
paritytech · paritytech-processbot · Dec 4, 2022 · Sep 26, 2022 · Sep 27, 2022 · Nov 25, 2022
commit 3edcfaebe3d6ed16d3efb2146f1c1329b2afb6eb
diff --git a/frame/executive/src/lib.rs b/frame/executive/src/lib.rs
@@ -501,7 +501,7 @@ where
 		// Mandatory(inherents) are not allowed to fail.
 		//
 		// The entire block should be discarded if an inherent fails to apply. Otherwise
-		// it may opens some attack vector.
+		// it may open an attack vector.
 		if r.is_err() && dispatch_info.class == DispatchClass::Mandatory {
 	/// A mandatory dispatch. These kinds of dispatch are always included regardless of their 
 	/// weight, therefore it is critical that they are separately validated to ensure that a 
 	/// malicious validator cannot craft a valid but impossibly heavy block. Usually this just 
 	/// means ensuring that the extrinsic can only be included once and that it is always very 
 	/// light. 
 	/// 
 	/// Do *NOT* use it for extrinsics that can be heavy. 
 	/// 
 	/// The only real use case for this is inherent extrinsics that are required to execute in a 
 	/// block for the block to be valid, and it solves the issue in the case that the block 
 	/// initialization is sufficiently heavy to mean that those inherents do not fit into the 
 	/// block. Essentially, we assume that in these exceptional circumstances, it is better to 
 	/// allow an overweight block to be created than to not allow any block at all to be created. 
 	Mandatory, 
 	/// A mandatory dispatch. These kinds of dispatch are always included regardless of their 
 	/// weight, therefore it is critical that they are separately validated to ensure that a 
 	/// malicious validator cannot craft a valid but impossibly heavy block. Usually this just 
 	/// means ensuring that the extrinsic can only be included once and that it is always very 
 	/// light. 
 	/// 
 	/// Do *NOT* use it for extrinsics that can be heavy. 
 	/// 
 	/// The only real use case for this is inherent extrinsics that are required to execute in a 
 	/// block for the block to be valid, and it solves the issue in the case that the block 
 	/// initialization is sufficiently heavy to mean that those inherents do not fit into the 
 	/// block. Essentially, we assume that in these exceptional circumstances, it is better to 
 	/// allow an overweight block to be created than to not allow any block at all to be created. 
 	Mandatory, 
 			return Err(InvalidTransaction::BadMandatory.into())
 		}