Remove no-op value_parsers

client/cli/src/commands/export_blocks_cmd.rs

@@ -32,7 +32,7 @@ use std::{fmt::Debug, fs, io, path::PathBuf, str::FromStr, sync::Arc};
 #[derive(Debug, Clone, Parser)]
 pub struct ExportBlocksCmd {
 	/// Output file name or stdout if unspecified.
-	#[arg(value_parser)]
+	#[arg()]
 	pub output: Option<PathBuf>,
 
 	/// Specify starting block number.

client/cli/src/commands/import_blocks_cmd.rs

@@ -37,7 +37,7 @@ use std::{
 #[derive(Debug, Parser)]
 pub struct ImportBlocksCmd {
 	/// Input file or stdin if unspecified.
-	#[arg(value_parser)]
+	#[arg()]
 	pub input: Option<PathBuf>,
 
 	/// The default number of 64KB pages to ever allocate for Wasm execution.

client/cli/src/params/import_params.rs

@@ -87,7 +87,7 @@ pub struct ImportParams {
 	/// Specify the path where local WASM runtimes are stored.
 	///
 	/// These runtimes will override on-chain runtimes when the version matches.
-	#[arg(long, value_name = "PATH", value_parser)]
+	#[arg(long, value_name = "PATH")]
 	pub wasm_runtime_overrides: Option<PathBuf>,
 
 	#[allow(missing_docs)]

client/cli/src/params/keystore_params.rs

@@ -36,7 +36,7 @@ pub struct KeystoreParams {
 	pub keystore_uri: Option<String>,
 
 	/// Specify custom keystore path.
-	#[arg(long, value_name = "PATH", value_parser)]
+	#[arg(long, value_name = "PATH")]
 	pub keystore_path: Option<PathBuf>,
 
 	/// Use interactive shell for entering the password used by the keystore.
@@ -56,7 +56,6 @@ pub struct KeystoreParams {
 	#[arg(
 		long,
 		value_name = "PATH",
-		value_parser,
 		conflicts_with_all = &["password_interactive", "password"]
 	)]
 	pub password_filename: Option<PathBuf>,

client/cli/src/params/shared_params.rs

@@ -39,7 +39,7 @@ pub struct SharedParams {
 	pub dev: bool,
 
 	/// Specify custom base path.
-	#[arg(long, short = 'd', value_name = "PATH", value_parser)]
+	#[arg(long, short = 'd', value_name = "PATH")]
 	pub base_path: Option<PathBuf>,
 
 	/// Sets a custom logging filter. Syntax is <target>=<level>, e.g. -lsync=debug.

scripts/ci/node-template-release/Cargo.toml

@@ -10,7 +10,7 @@ homepage = "https://substrate.io"
 targets = ["x86_64-unknown-linux-gnu"]
 
 [dependencies]
-clap = { version = "3.0", features = ["derive"] }
+clap = { version = "4.0.9", features = ["derive", "deprecated"] }
 flate2 = "1.0"
 fs_extra = "1"
 git2 = "0.8"

scripts/ci/node-template-release/src/main.rs

@@ -29,10 +29,10 @@ type CargoToml = HashMap<String, toml::Value>;
 #[derive(Parser)]
 struct Options {
 	/// The path to the `node-template` source.
-	#[arg(value_parser)]
+	#[arg()]
 	node_template: PathBuf,
 	/// The path where to output the generated `tar.gz` file.
-	#[arg(value_parser)]
+	#[arg()]
 	output: PathBuf,
 }