Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

MMR: impl TypeInfo for some structures #12423

Merged
serban300 merged 2 commits into from
Oct 5, 2022
Merged

MMR: impl TypeInfo for some structures #12423

serban300 merged 2 commits into from
Oct 5, 2022

Conversation

@serban300
Copy link
Contributor

@serban300 serban300 commented Oct 5, 2022 •
edited
Loading

Related to: paritytech/parity-bridges-common#2469

We are working on implementing BEEFY finality in the bridges project and as part of this we'll need to pass MmrLeaf and Mmr Proof/BatchProof structures as parameters for extrinsics. In order to do this we need them to implement TypeInfo.

@serban300 serban300 added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Oct 5, 2022
@serban300 serban300 self-assigned this Oct 5, 2022
@serban300 serban300 requested a review from acatangiu as a code owner October 5, 2022 12:11
@acatangiu
Copy link
Contributor

acatangiu commented Oct 5, 2022

bot merge

@paritytech-processbot
Copy link

paritytech-processbot bot commented Oct 5, 2022

Waiting for commit status.

@paritytech-processbot
Copy link

paritytech-processbot bot commented Oct 5, 2022

Merge cancelled due to error. Error: Statuses failed for 536bc57

@serban300
Copy link
Contributor Author

serban300 commented Oct 5, 2022

bot merge

@serban300 serban300 merged commit 2cd4088 into paritytech:master Oct 5, 2022
@serban300 serban300 mentioned this pull request Oct 5, 2022
Open
@paritytech-processbot
Copy link

paritytech-processbot bot commented Oct 5, 2022

Error: Github API says #12423 is not mergeable

ordian pushed a commit that referenced this pull request Oct 5, 2022
Merge branch 'master' into ao-update-kvdb-and-co
d31a98d 
* master:
  Implement `Clone` and `Default` for `Config` (#12397)
  Don't send back empty proofs if light request fails (#12372)
  MMR: impl `TypeInfo` for some structures (#12423)
@aurexav aurexav mentioned this pull request Jan 10, 2023
Closed
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
@serban300 @ark0f
MMR: impl TypeInfo for some structures (paritytech#12423)
cc03d6a 
* BEEFY client: avoid unnecessary clone

* MMR: impl TypeInfo for some structures
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@svyatonik svyatonik Awaiting requested review from svyatonik

2 more reviewers

@Lederstrumpf Lederstrumpf Lederstrumpf approved these changes

@acatangiu acatangiu acatangiu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@serban300 serban300

Labels

A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@serban300 @acatangiu @Lederstrumpf