Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Avoid Unstable Sort #12455

Merged
paritytech-processbot merged 3 commits into from
Oct 11, 2022
Merged

Avoid Unstable Sort #12455

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2b71ba6
dont use unstable sort
shawntabrizi Oct 9, 2022
1f3bcb4
remove comment
shawntabrizi Oct 9, 2022
9c97230
add clippy rule
shawntabrizi Oct 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove comment
  • Loading branch information
@shawntabrizi
shawntabrizi committed Oct 9, 2022
commit 1f3bcb4aa2d25463d5abb9248b0bc604d6be1f2c
4 changes: 0 additions & 4 deletions frame/contracts/src/wasm/runtime.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1976,10 +1976,6 @@ pub mod env {
data_len: u32,
) -> Result<(), TrapReason> {
fn has_duplicates<T: Ord>(items: &mut Vec<T>) -> bool {
// # Warning
//
// Unstable sorts are non-deterministic across architectures. The usage here is OK
// because we are rejecting duplicates which removes the non determinism.
items.sort();
// Find any two consecutive equal elements.
items.windows(2).any(|w| match &w {
Expand Down