Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

registrar: Avoid freebies in provide_judgement #12465

Merged
paritytech-processbot merged 9 commits into from
Oct 19, 2022
Merged

registrar: Avoid freebies in provide_judgement #12465

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7f23a5c
evaluate repatriate reserved error in pallet identity
dharjeezy Oct 10, 2022
ca35ea2
fix benchmarks
dharjeezy Oct 12, 2022
74d8c38
add repatriate reserved error test
dharjeezy Oct 13, 2022
6e129cb
benchmark fix
dharjeezy Oct 15, 2022
a1c0588
undo lock
dharjeezy Oct 15, 2022
d3e2079
include balance to use for benchmarks
dharjeezy Oct 16, 2022
10f88fa
rename test
dharjeezy Oct 17, 2022
fd3ba92
Update frame/identity/src/benchmarking.rs
bkchr Oct 19, 2022
2842879
Update frame/identity/src/benchmarking.rs
bkchr Oct 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
benchmark fix
  • Loading branch information
@dharjeezy
dharjeezy committed Oct 15, 2022
commit 6e129cb400c99b53becebaf2a48fb8ee109fa726
1 change: 1 addition & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 7 additions & 7 deletions frame/identity/src/benchmarking.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ fn add_registrars<T: Config>(r: u32) -> Result<(), &'static str> {
let _ = T::Currency::make_free_balance_be(&registrar, BalanceOf::<T>::max_value());
let registrar_origin = T::RegistrarOrigin::successful_origin();
Identity::<T>::add_registrar(registrar_origin, registrar_lookup)?;
Identity::<T>::set_fee(RawOrigin::Signed(registrar.clone()).into(), i, 10u32.into())?;
Identity::<T>::set_fee(RawOrigin::Signed(registrar.clone()).into(), i, 0u32.into())?;
let fields =
IdentityFields(
IdentityField::Display |
Expand Down Expand Up @@ -148,7 +148,7 @@ benchmarks! {
let registrar_lookup = T::Lookup::unlookup(registrar.clone());
let _ = T::Currency::make_free_balance_be(&registrar, 10u32.into());

Identity::<T>::request_judgement(caller_origin.clone(), i, 10u32.into())?;
Identity::<T>::request_judgement(caller_origin.clone(), i, 0u32.into())?;
Identity::<T>::provide_judgement(
RawOrigin::Signed(registrar).into(),
i,
Expand Down Expand Up @@ -221,7 +221,7 @@ benchmarks! {
let registrar_lookup = T::Lookup::unlookup(registrar.clone());
let _ = T::Currency::make_free_balance_be(&registrar, 10u32.into());

Identity::<T>::request_judgement(caller_origin.clone(), i, 10u32.into())?;
Identity::<T>::request_judgement(caller_origin.clone(), i, 0u32.into())?;
Identity::<T>::provide_judgement(
RawOrigin::Signed(registrar).into(),
i,
Expand All @@ -248,7 +248,7 @@ benchmarks! {
let caller_origin = <T as frame_system::Config>::RuntimeOrigin::from(RawOrigin::Signed(caller));
Identity::<T>::set_identity(caller_origin, Box::new(info))?;
};
}: _(RawOrigin::Signed(caller.clone()), r - 1, 10u32.into())
}: _(RawOrigin::Signed(caller.clone()), r - 1, 0u32.into())
verify {
assert_last_event::<T>(Event::<T>::JudgementRequested { who: caller, registrar_index: r-1 }.into());
}
Expand All @@ -267,7 +267,7 @@ benchmarks! {
Identity::<T>::set_identity(caller_origin, Box::new(info))?;
};

Identity::<T>::request_judgement(caller_origin, r - 1, 10u32.into())?;
Identity::<T>::request_judgement(caller_origin, r - 1, 0u32.into())?;
}: _(RawOrigin::Signed(caller.clone()), r - 1)
verify {
assert_last_event::<T>(Event::<T>::JudgementUnrequested { who: caller, registrar_index: r-1 }.into());
Expand Down Expand Up @@ -348,7 +348,7 @@ benchmarks! {

let registrar_origin = T::RegistrarOrigin::successful_origin();
Identity::<T>::add_registrar(registrar_origin, caller_lookup)?;
Identity::<T>::request_judgement(user_origin, r, 10u32.into())?;
Identity::<T>::request_judgement(user_origin, r, 0u32.into())?;
}: _(RawOrigin::Signed(caller), r, user_lookup, Judgement::Reasonable, info_hash)
verify {
assert_last_event::<T>(Event::<T>::JudgementGiven { target: user, registrar_index: r }.into())
Expand All @@ -374,7 +374,7 @@ benchmarks! {
let registrar_lookup = T::Lookup::unlookup(registrar.clone());
let _ = T::Currency::make_free_balance_be(&registrar, 10u32.into());

Identity::<T>::request_judgement(target_origin.clone(), i, 10u32.into())?;
Identity::<T>::request_judgement(target_origin.clone(), i, 0u32.into())?;
Identity::<T>::provide_judgement(
RawOrigin::Signed(registrar).into(),
i,
Expand Down