This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Use ArgAction::Set for enable-offchain-indexing flag
#12521
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up for #12381
There are some places where we pass
enable-offchain-indexing=trueto binaries.This does not work by default anymore in clap 4 which uses
ArgAction::SetTrueas default. This means that the occurence of the flag sets the value to true and additional values are not allowed.While I think the new approach makes more sense, there are some users of this flag and we should not break it if not necessary.