Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Chain head subscription #126

Merged
gavofyork merged 16 commits into from
Apr 17, 2018
Merged

Chain head subscription #126

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
a516ede
Start WebSockets server.
tomusdrw Apr 13, 2018
af81785
Expose non-working subscription.
tomusdrw Apr 13, 2018
af88a13
Merge branch 'master' into td-pubsub
tomusdrw Apr 13, 2018
292db18
Dummy subscription for testing.
tomusdrw Apr 13, 2018
8816443
Proper implementation with event loop.
tomusdrw Apr 13, 2018
d7b2734
Finalized pubsub.
tomusdrw Apr 13, 2018
b31f0d5
Bump clap.
tomusdrw Apr 13, 2018
7f3a621
Fix yml.
tomusdrw Apr 13, 2018
af7f683
Disable WS logs.
tomusdrw Apr 13, 2018
789ea46
Merge branch 'master' into td-pubsub
gavofyork Apr 15, 2018
9193b89
Remove stale TransactionHash mention
gavofyork Apr 15, 2018
921d7c4
Fix build from nightly API change.
gavofyork Apr 15, 2018
73106ab
Don't panic on invalid port.
tomusdrw Apr 16, 2018
2da7ac0
Bind server to random port.
tomusdrw Apr 16, 2018
eaba689
Merge branch 'master' into td-pubsub
tomusdrw Apr 16, 2018
704f755
Send only best blocks.
tomusdrw Apr 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Send only best blocks.
  • Loading branch information
@tomusdrw
tomusdrw committed Apr 17, 2018
commit 704f755dc5c979d58b535a714e3f13f8147ca6af
1 change: 1 addition & 0 deletions substrate/rpc/src/chain/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ impl<B, E> ChainApi for Chain<B, E> where
fn subscribe_new_head(&self, _metadata: Self::Metadata, subscriber: pubsub::Subscriber<block::Header>) {
self.subscriptions.add(subscriber, |sink| {
let stream = self.client.import_notification_stream()
.filter(|notification| notification.is_new_best)
.map(|notification| Ok(notification.header))
Copy link
Member

@arkpar arkpar Apr 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should filter by notification.is_best

.map_err(|e| warn!("Block notification stream error: {:?}", e));
sink
Expand Down