This repository was archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
permissionless bond_extra in nomination pools
#12608
Merged
paritytech-processbot
merged 63 commits into
paritytech:master
from
Doordashcon:ddc-MCF-T1
Feb 22, 2023
Merged
Changes from 1 commit
Commits
Show all changes
63 commits
Select commit
Hold shift + click to select a range
c5cde02
create enum
3ab9cd7
logic check
59958d5
add benchmarks
9d54b8a
-enum
8efecfe
Merge branch 'paritytech:master' into ddc-MCF-T1
f7b0a2d
update
8931433
bond extra other
9f83103
update
9d63fdb
update
a3718f6
update
4c6a4e7
cargo fmt
8207d51
Permissioned
0401174
Merge branch 'paritytech:master' into ddc-MCF-T1
a4b6ec2
update
db9c1b8
cargo fmt
4d8bc6f
Merge branch 'paritytech:master' into ddc-MCF-T1
b5eda08
update
58173e0
Merge branch 'paritytech:master' into ddc-MCF-T1
b110526
update index
126bc8d
Merge branch 'paritytech:master' into ddc-MCF-T1
a45d615
doc update
ab1e7bb
doc update
ab064f7
Merge branch 'paritytech:master' into ddc-MCF-T1
5f25374
cargo fmt
619e9b9
bond_extra auto compound
15c286f
bond_extra_other
1a1479d
Merge branch 'paritytech:master' into ddc-MCF-T1
b21097b
Merge branch 'paritytech:master' into ddc-MCF-T1
4ffe8f5
Merge branch 'paritytech:master' into ddc-MCF-T1
fcd63b2
Apply suggestions from code review
kianenigma f6254fa
Fixes from kian
kianenigma ce1ebc9
updates docs & test
62edda4
Merge remote-tracking branch 'origin/master' into ddc-MCF-T1
1211229
Update frame/nomination-pools/src/lib.rs
6e4f2b4
Update frame/nomination-pools/src/lib.rs
832281d
Update frame/nomination-pools/src/lib.rs
e242799
Update frame/nomination-pools/src/lib.rs
011d733
Update frame/nomination-pools/src/lib.rs
d9590b1
Update frame/nomination-pools/src/tests.rs
04d6b13
Update frame/nomination-pools/src/lib.rs
b8be98c
Update frame/nomination-pools/src/tests.rs
d8fac0e
Update frame/nomination-pools/src/tests.rs
79f9b7e
Update frame/nomination-pools/src/tests.rs
184d6f2
Update frame/nomination-pools/src/tests.rs
0e0cc6f
Update frame/nomination-pools/src/tests.rs
be3cc5e
Update frame/nomination-pools/src/lib.rs
768c63d
Update frame/nomination-pools/src/tests.rs
549a743
fixes + fmt
e823b43
Merge remote-tracking branch 'origin/master' into ddc-MCF-T1
1c17bcc
expand ClaimPermissions + add benchmarks
9b1eb00
".git/.scripts/commands/bench/bench.sh" pallet dev pallet_nomination_…
9996341
tidy up claim payout benches
6fa711c
fix
0f9f730
+ test: claim_payout_other_works
4bdf22a
comments, rename to set_claim_permission
2965fd9
fix comment
7c16c8e
remove ClaimPermission on leave pool
ef63fdf
fix test
f8cedba
".git/.scripts/commands/fmt/fmt.sh"
4ac673b
Merge remote-tracking branch 'origin/master' into ddc-MCF-T1
0ea2309
+ test for ClaimPermissions::remove()
a39573c
impl can_bond_extra & can_claim_payout
f7a6568
Merge remote-tracking branch 'origin/master' into ddc-MCF-T1
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
update index
- Loading branch information
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I may have asked this before, but can't this be one transaction with the existing
bond_extra? and even if we want to keep them separate, shan't they share most of the internal code?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it does share most of the internal code of
bond_extra, it excludes transferring pending rewards to the member from thedo_reward_payouthelper function and instead transfers the pending reward directly to the bounding account fromtry_bound_fundand increment the points accordingly.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kianenigma Yes an extra parameter
other: Option<AccountId>can be added tobond_extrathen the claimed rewards will be bonded for the account specified inother.