Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

perf: generate_initial_session_keys: load runtime only if its relevant #12651

Merged
bkchr merged 5 commits into from
Nov 22, 2022
Merged

perf: generate_initial_session_keys: load runtime only if its relevant #12651

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d53835b
perf: generate_initial_session_keys: load runtime only if its relevant
librelois Nov 8, 2022
84ec23a
apply review suggestion
librelois Nov 8, 2022
65b7bcb
Merge branch 'master' into elois_perf_gen_initial_session_keys
librelois Nov 9, 2022
3dce033
Update primitives/session/src/lib.rs
librelois Nov 21, 2022
a1f387e
Merge branch 'master' into elois_perf_gen_initial_session_keys
librelois Nov 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
apply review suggestion
  • Loading branch information
@librelois
librelois committed Nov 8, 2022
commit 84ec23a208ea74c68644a2c7bf599db7725f5bae
10 changes: 6 additions & 4 deletions primitives/session/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,11 +119,13 @@ where
T::Api: SessionKeys<Block>,
{
if !seeds.is_empty() {
Copy link
Contributor

@crystalin crystalin Nov 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it easier to:

if seeds.is_empty() {
  return Ok(())
}

Copy link
Contributor Author

@librelois librelois Nov 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A question of style, after compilation it is strictly equivalent.

Copy link
Member

@davxy davxy Nov 8, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. But stylistically speaking maybe is better to early exit when the initial conditions are not met (just to avoid a dummy indentation over all the function body)

But this is only my opinion :-D

Copy link
Contributor Author

@librelois librelois Nov 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

let runtime_api = client.runtime_api();
return Ok(())
}

let runtime_api = client.runtime_api();

for seed in seeds {
runtime_api.generate_session_keys(at, Some(seed.as_bytes().to_vec()))?;
}
for seed in seeds {
runtime_api.generate_session_keys(at, Some(seed.as_bytes().to_vec()))?;
}

Ok(())
Expand Down