Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
try runtime fixes
  • Loading branch information
muharem committed Nov 27, 2022
commit 9101c5ae26b68bae8b07f82c74e102b17ecda40a
8 changes: 4 additions & 4 deletions frame/referenda/src/migration.rs
Original file line number Diff line number Diff line change
Expand Up @@ -101,10 +101,10 @@ pub mod v1 {
let referendum_count = v0::ReferendumInfoFor::<T, I>::iter().count();
log::info!(
target: TARGET,
"pre-upgrade state contains '%d' referendums.",
referenda_count
"pre-upgrade state contains '{}' referendums.",
referendum_count
);
Ok((referendum_count as u32).encode());
Ok((referendum_count as u32).encode())
}

fn on_runtime_upgrade() -> Weight {
Expand Down Expand Up @@ -150,7 +150,7 @@ pub mod v1 {
assert_eq!(onchain_version, 1, "must upgrade from version 0 to 1.");
let pre_referendum_count: u32 = Decode::decode(&mut &state[..])
.expect("failed to decode the state from pre-upgrade.");
let post_referendum_count = ReferendumInfoFor::<T, I>::iter().count();
let post_referendum_count = ReferendumInfoFor::<T, I>::iter().count() as u32;
assert_eq!(
post_referendum_count, pre_referendum_count,
"must migrate all referendums."
Expand Down
4 changes: 2 additions & 2 deletions frame/referenda/src/types.rs
Original file line number Diff line number Diff line change
Expand Up @@ -264,8 +264,8 @@ impl<
match self {
// Cannot refund deposit if Ongoing as this breaks assumptions.
Ongoing(_) => Err(()),
Approved(_, d, _) | Rejected(_, d, _) | TimedOut(_, d, _) | Cancelled(_, d, _) =>
Ok(d.take()),
Approved(_, s, _) | Rejected(_, s, _) | TimedOut(_, s, _) | Cancelled(_, s, _) =>
Ok(s.take()),
Killed(_) => Ok(None),
}
}
Expand Down