Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Conversation

@gavofyork
Copy link
Member

Quantization calculation of the referenda alarm was wrong and resulted in it being in the past. This fixes it.

@gavofyork gavofyork added the A0-please_review Pull request needs code review. label Dec 1, 2022
@gavofyork gavofyork added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Dec 1, 2022
@gavofyork
Copy link
Member Author

@muharem final approval, please.

@gavofyork
Copy link
Member Author

@ggwpez @KiChjang quick review?

@gavofyork gavofyork merged commit c17c7d8 into master Dec 2, 2022
@gavofyork gavofyork deleted the gav-fix-referenda-alarm branch December 2, 2022 13:17
ltfschoen pushed a commit to ltfschoen/substrate that referenced this pull request Feb 22, 2023
* Fix quantization in referenda alarm

* Formatting

* alarm interval, test (paritytech#12818)

Co-authored-by: Muharem Ismailov <[email protected]>
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
* Fix quantization in referenda alarm

* Formatting

* alarm interval, test (paritytech#12818)

Co-authored-by: Muharem Ismailov <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants