Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Runtime diagnostics for leaked messages in unbounded channels #12971

Merged
dmitry-markin merged 15 commits into from
Dec 23, 2022
Merged

Runtime diagnostics for leaked messages in unbounded channels #12971

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
793a5fd
minor: remove event count argument from `Metrics::event_in()` that is…
dmitry-markin Dec 16, 2022
2b661e2
OutChannel queue size warning
dmitry-markin Dec 16, 2022
3144bd5
Attach creation backtrace to channal for queue size warning reporting
dmitry-markin Dec 19, 2022
49720f2
rustfmt
dmitry-markin Dec 19, 2022
c640cbf
minor: convert tuple into struct
dmitry-markin Dec 19, 2022
972b452
minor: renaming
dmitry-markin Dec 19, 2022
1bb9602
Simplify queue size couting logic by using signed integer
dmitry-markin Dec 20, 2022
69f2727
Warn if there is clogging in utils::mpsc::tracing_unbounded()
dmitry-markin Dec 20, 2022
cacf5b9
Set mpsc::tracing_unbounded() queue size warning thresholds
dmitry-markin Dec 20, 2022
82e1b1e
Make unbounded channel in `network/transactions` metered
dmitry-markin Dec 20, 2022
75a3389
Make unbounded channel in `telemetry` metered
dmitry-markin Dec 20, 2022
94b7254
Merge remote-tracking branch 'origin/master' into dm-unbounded-channe…
dmitry-markin Dec 20, 2022
0d527bc
Fix warning
dmitry-markin Dec 20, 2022
709efba
Make rustdoc happy
dmitry-markin Dec 20, 2022
2706277
Expand doc
dmitry-markin Dec 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
rustfmt
  • Loading branch information
@dmitry-markin
dmitry-markin committed Dec 19, 2022
commit 49720f283e7cc427296ea72f2cc99dc6ec9c181a
4 changes: 1 addition & 3 deletions client/network/src/service/out_events.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,9 +192,7 @@ impl OutChannels {
error!(
"The number of unprocessed events in channel `{}` reached {}.\n\
The channel was created at:\n{}",
sender.name,
sender.queue_size_warning,
sender.created_backtrace,
sender.name, sender.queue_size_warning, sender.created_backtrace,
);
}
sender.inner.unbounded_send(event.clone()).is_ok()
Expand Down