This repository was archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Aura: Do not verify on state import #13058
Merged
paritytech-processbot
merged 4 commits into
master
from
bkchr-aura-do-not-verify-on-state-import
Jan 4, 2023
Merged
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -174,7 +174,7 @@ where | |
| #[async_trait::async_trait] | ||
| impl<B: BlockT, C, P, CIDP> Verifier<B> for AuraVerifier<C, P, CIDP, NumberFor<B>> | ||
| where | ||
| C: ProvideRuntimeApi<B> + Send + Sync + sc_client_api::backend::AuxStore, | ||
| C: ProvideRuntimeApi<B> + Send + Sync + sc_client_api::backend::AuxStore + HeaderBackend<B>, | ||
| C::Api: BlockBuilderApi<B> + AuraApi<B, AuthorityId<P>> + ApiExt<B>, | ||
| P: Pair + Send + Sync + 'static, | ||
| P::Public: Send + Sync + Hash + Eq + Clone + Decode + Encode + Debug + 'static, | ||
|
|
@@ -186,6 +186,25 @@ where | |
| &mut self, | ||
| mut block: BlockImportParams<B, ()>, | ||
| ) -> Result<(BlockImportParams<B, ()>, Option<Vec<(CacheKeyId, Vec<u8>)>>), String> { | ||
| // When importing whole state we don't verify the seal as the state is not available. | ||
| if block.with_state() { | ||
| return Ok((block, Default::default())) | ||
| } | ||
|
|
||
| let info = self.client.info(); | ||
|
|
||
| // If we are importing a block in the gap, we skip all checks. | ||
| // | ||
| // It is expected that the block after the gap was checked/chosen properly, e.g. by warp | ||
| // syncing to this block. | ||
| if info | ||
|
||
| .block_gap | ||
| .map(|(start, end)| start <= *block.header.number() && *block.header.number() <= end) | ||
| .unwrap_or(false) | ||
| { | ||
| return Ok((block, Default::default())) | ||
| } | ||
|
|
||
| let hash = block.header.hash(); | ||
| let parent_hash = *block.header.parent_hash(); | ||
| let authorities = authorities( | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.