This repository was archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
service: storage monitor added #13082
Merged
Merged
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
34577eb
service: storage monitor added
michalkucharczyk b5f970b
Merge remote-tracking branch 'origin/master' into mku-storage-monitor
michalkucharczyk 37bbba4
Cargo.lock updated
michalkucharczyk ba0f28f
misspell
michalkucharczyk e360685
fs events throttling added
michalkucharczyk fd5679f
minor updates
michalkucharczyk 217234f
filter out non mutating events
michalkucharczyk 8b3310b
misspell
michalkucharczyk 931339c
".git/.scripts/commands/fmt/fmt.sh"
c200159
Update client/service/src/storage_monitor.rs
michalkucharczyk f5501f2
storage-monitor crate added
michalkucharczyk 45171dc
cleanup: configuration + service builder
michalkucharczyk f346394
storage_monitor in custom service (wip)
michalkucharczyk eb49400
copy-paste bad desc fixed
michalkucharczyk 8619766
notify removed
michalkucharczyk a0cd44d
storage_monitor added to node
michalkucharczyk d3f143c
Merge remote-tracking branch 'origin/master' into mku-storage-monitor
a79af9a
fix for clippy
michalkucharczyk 00e7264
publish = false
michalkucharczyk 6c3eb1c
Update bin/node/cli/src/command.rs
michalkucharczyk 58dcf55
Apply suggestions from code review
michalkucharczyk 95b576b
crate name: storage-monitor -> sc-storage-monitor
michalkucharczyk 0b8697e
error handling improved
michalkucharczyk c0fc2ca
Merge remote-tracking branch 'origin/master' into mku-storage-monitor
michalkucharczyk de35dda
Apply suggestions from code review
michalkucharczyk 4e32f3d
publish=false removed
michalkucharczyk 0578588
Merge remote-tracking branch 'origin/master' into mku-storage-monitor
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fs events throttling added
- Loading branch information
commit e36068584c6f365c11d995c0935e5727e888b86d
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also wondering how did you end up choosing 2 sec? why not 5 or 10s? or even 60s? do you know the avg disk space growth rate in polkadot?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a guess. The syscall is cheap, should not affect the system. I did not measure the usage by node, but there also can be other consumers of storage running on the machine.
I also added a param, so anyone can adjust if required.