This repository was archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
[Feature] Introduce storage_alias for CountedStorageMap #13366
Merged
Merged
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
43b36a5
[Feature] Introduce storagage_alias for CountedStorageMap
ruseinov 1e45f30
bit more dry
ruseinov fc974b3
bit more dry
ruseinov b410020
address review comments
ruseinov 60ab3e8
some tests and fixes
ruseinov 51c45d3
Merge remote-tracking branch 'origin/master' into ru/feature/storage-…
82c71f9
fix ui tests
ruseinov 7ed34ff
Apply suggestions from code review
ruseinov 79378d1
compare metadata
ruseinov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
bit more dry
- Loading branch information
commit fc974b37b47c29afb75bf45267e613bd7e49e3f1
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||
|---|---|---|---|---|
|
|
@@ -595,9 +595,7 @@ fn generate_storage_instance( | |||
| let name = Ident::new(&format!("{}_Storage_Instance", storage_name), Span::call_site()); | ||||
| let storage_name_str = storage_name.to_string(); | ||||
|
|
||||
| let mut counter_code = Option::None; | ||||
|
|
||||
| if is_counted_map { | ||||
| let counter_code = is_counted_map.then(|| { | ||||
| let counter_name = Ident::new(&format!("Counter_{}", name), Span::call_site()); | ||||
| let counter_storage_name_str = "counter_".to_owned() + &storage_name_str; | ||||
|
||||
| fn counter_prefix(prefix: &str) -> String { |
Move it somewhere in the crate to reuse it
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good spot, going to check this out!
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.