Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Improve handling of unset StorageVersion #13417

Merged
bkchr merged 16 commits into from
May 4, 2023
Merged

Improve handling of unset StorageVersion #13417

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
57d5de1
Improve handling of unset `StorageVersion`
bkchr Jan 5, 2023
35ec109
Use correct `Cargo.lock`
bkchr Feb 19, 2023
21595de
Fixes
bkchr Feb 20, 2023
2467c47
Fix test
bkchr Feb 20, 2023
f0b844b
Update frame/support/test/tests/pallet.rs
bkchr Feb 20, 2023
1732b68
Merge remote-tracking branch 'origin/master' into bkchr-something-sto…
bkchr Apr 27, 2023
399af7b
Ensure we don't set a storage version when the pallet is missing the …
bkchr Apr 27, 2023
f4faffc
Fix merge conflict
bkchr Apr 28, 2023
cfefade
Update frame/support/procedural/src/pallet/expand/hooks.rs
bkchr Apr 28, 2023
43ee1a0
Update frame/support/procedural/src/pallet/expand/hooks.rs
bkchr Apr 28, 2023
8021dfa
Fix compilation
bkchr Apr 28, 2023
7f0626b
Do not run everything with `try-runtime`
bkchr Apr 28, 2023
2babce7
Fix test
bkchr May 2, 2023
8451fc5
Apply suggestions from code review
bkchr May 2, 2023
2ff5428
Fix `no-metadata-docs`
bkchr May 3, 2023
dd3ccd0
Merge remote-tracking branch 'origin/master' into bkchr-something-sto…
May 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update frame/support/procedural/src/pallet/expand/hooks.rs 
Co-authored-by: Roman Useinov <[email protected]>
  • Loading branch information
@bkchr @ruseinov
bkchr and ruseinov authored Apr 28, 2023
commit 43ee1a09307e6ed1fce9060cb39a3484f1a759b5
2 changes: 1 addition & 1 deletion frame/support/procedural/src/pallet/expand/hooks.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ pub fn expand_hooks(def: &mut Def) -> proc_macro2::TokenStream {
while the pallet is missing the `#[pallet::storage_version(VERSION)]` attribute.",
);

return Err("On chain storage version set, while pallet doesn't \
return Err("On chain storage version set, while the pallet doesn't \
Copy link
Member

@ggwpez ggwpez Apr 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit: you could collect all those errors in a vector and return them at the end. Then we can debug multiple erroneous pallets at once, like in Rococo.

have the `#[pallet::storage_version(VERSION)]` attribute.");
}
}
Expand Down