Yieldable queues for pallet `MessageQueue` by ggwpez · Pull Request #13424 · paritytech/substrate

ggwpez · 2023-02-20T14:26:56Z

Preparation for: paritytech/cumulus#2157

Changes:

🚨 Adds a Yield variant to the ProcessMessageError enum. This indicates that a queue wants to yield its service slot.
Can be used to "pause" queues in a trivial way; the MQ pallet does not need to store any additional state about paused queues and the processor needs to re-check his paused-condition on each invocation anyway.
Adds a NoopServiceQueues impl, since ServiceQueues cannot be implemented for () due to its associated type.
🚨 Changes process_message to use a &mut WeightMeter instead of Weight return to also consume weight in the error case.

and 3. are breaking changes, but AFAIK the MQ pallet is not yet used downstream, therefore no migration is provided.

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

ggwpez · 2023-02-24T14:46:09Z

bot bench $ pallet dev pallet_message_queue

command-bot · 2023-02-24T14:46:14Z

@ggwpez https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2442244 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet dev pallet_message_queue. Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 76-49674869-4b50-40c3-856e-8e4373964168 to cancel this command or bot cancel to cancel all commands in this pull request.

… HEAD

command-bot · 2023-02-24T15:10:46Z

@ggwpez Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet dev pallet_message_queue has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2442244 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2442244/artifacts/download.

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

ggwpez · 2023-02-25T16:13:12Z

bot merge

Polkadot-Forum · 2023-03-30T10:12:46Z

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/polkadot-release-analysis-v0-9-40/2468/1

* Add Yield message processing error Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Add NoopServiceQueues Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Implement temporary error aka Yield Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Make NoopMessageProcessor generic Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Mock pausable message processor Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Test paused queues Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Integration test paused queues Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Use WeightMeter instead of weight return Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * fix Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Make compile Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Add tests Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_message_queue * Fix test Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: command-bot <>

ggwpez added 7 commits February 20, 2023 15:06

Add Yield message processing error

db2435d

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

Add NoopServiceQueues

3356f84

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

Implement temporary error aka Yield

136d262

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

Make NoopMessageProcessor generic

2d3995d

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

Mock pausable message processor

de51887

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

Test paused queues

47fb626

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

Integration test paused queues

4d18efe

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

ggwpez requested a review from gavofyork February 20, 2023 14:28

ggwpez mentioned this pull request Feb 20, 2023

Use Message Queue as DMP and XCMP dispatch queue paritytech/cumulus#2157

Open

10 tasks

Use WeightMeter instead of weight return

5359dfd

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

ggwpez marked this pull request as ready for review February 21, 2023 17:50

ggwpez added 3 commits February 22, 2023 15:34

Merge remote-tracking branch 'origin/master' into oty-mp-queue

f5b2d44

fix

1ceb63b

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

Make compile

e13a7b2

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

gavofyork approved these changes Feb 23, 2023

View reviewed changes

Add tests

15a1088

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

ggwpez added the E0-runtime_migration PR introduces code that might require downstream chains to run a runtime upgrade. label Feb 24, 2023

command-bot added 2 commits February 24, 2023 14:46

Merge branch 'master' of https://github.com/paritytech/substrate into…

24792db

… HEAD

".git/.scripts/commands/bench/bench.sh" pallet dev pallet_message_queue

007c623

Fix test

8e3caf4

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

sam0x17 approved these changes Feb 24, 2023

View reviewed changes

paritytech-processbot bot merged commit 9526f04 into master Feb 25, 2023

paritytech-processbot bot deleted the oty-mp-queue branch February 25, 2023 16:13

gavofyork mentioned this pull request Feb 28, 2023

XCM: Implement a blocking barrier paritytech/polkadot#6670

Closed

redzsina added D1-audited 👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited and removed D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Mar 2, 2023

kiltbot mentioned this pull request Apr 3, 2023

3️⃣ [AUTOMATIC] Update Polkadot dependencies from 0.9.39 to 0.9.40 KILTprotocol/kilt-node#496

Closed

librelois mentioned this pull request Apr 6, 2023

Update substrate/polkadot/cumulus from v0.9.38 to v0.9.40 moonbeam-foundation/moonbeam#2200

Closed

kacperzuk-neti mentioned this pull request Jun 23, 2023

Polkadot v0.9.43 liberland/liberland_substrate#295

Merged

15 tasks

dmitrylavrenov mentioned this pull request Nov 28, 2023

Tracking issue to bump substrate related deps to polkadot-v0.9.40 humanode-network/humanode#839

Closed

46 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Yieldable queues for pallet `MessageQueue`#13424

Yieldable queues for pallet `MessageQueue`#13424
paritytech-processbot[bot] merged 15 commits intomasterfrom
oty-mp-queue

ggwpez commented Feb 20, 2023 •

edited

Loading

Uh oh!

ggwpez commented Feb 24, 2023

Uh oh!

command-bot bot commented Feb 24, 2023 •

edited

Loading

Uh oh!

command-bot bot commented Feb 24, 2023

Uh oh!

ggwpez commented Feb 25, 2023

Uh oh!

Polkadot-Forum commented Mar 30, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

ggwpez commented Feb 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ggwpez commented Feb 24, 2023

Uh oh!

command-bot bot commented Feb 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

command-bot bot commented Feb 24, 2023

Uh oh!

ggwpez commented Feb 25, 2023

Uh oh!

Polkadot-Forum commented Mar 30, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ggwpez commented Feb 20, 2023 •

edited

Loading

command-bot bot commented Feb 24, 2023 •

edited

Loading