fix

frame/assets/src/lib.rs

@@ -1541,14 +1541,14 @@ pub mod pallet {
 
 			let old_min_balance = details.min_balance;
 			let is_sufficient = details.is_sufficient;
+			// If the asset is marked as sufficient it won't be allowed to
+			// change the min_balance.
+			ensure!(!is_sufficient, Error::<T, I>::NoPermission);
+
 			// Ensure that either the new min_balance is less than old
 			// min_balance or there aren't any accounts holding the asset.
-			//
-			// If the asset is marked as sufficient we will only allow the owner
-			// to set the min_balance if the count of accounts holding the assets
-			// is zero.
 			ensure!(
-				(!is_sufficient && min_balance < old_min_balance) || details.accounts == 0,
+				min_balance < old_min_balance || details.accounts == 0,
 				Error::<T, I>::NoPermission
 			);
 

frame/assets/src/tests.rs

@@ -1125,12 +1125,6 @@ fn set_min_balance_should_work() {
 			Error::<Test>::NoPermission
 		);
 
-		assert_ok!(Assets::burn(RuntimeOrigin::signed(1), id, 1, 100));
-
-		// Works because there are no asset holders.
-		assert_ok!(Assets::set_min_balance(RuntimeOrigin::signed(1), id, 60));
-		assert_eq!(Asset::<Test>::get(id).unwrap().min_balance, 60);
-
 		// Make the asset not sufficient.
 		assert_ok!(Assets::force_asset_status(
 			RuntimeOrigin::root(),
@@ -1144,9 +1138,6 @@ fn set_min_balance_should_work() {
 			false
 		));
 
-		// We mint the asset again.
-		assert_ok!(Assets::mint(RuntimeOrigin::signed(1), id, 1, 100));
-
 		// Will execute because the new value of min_balance is less than the
 		// old value. 10 < 30
 		assert_ok!(Assets::set_min_balance(RuntimeOrigin::signed(1), id, 10));