Fixes as per review comments

frame/support/procedural/src/pallet/parse/pallet_struct.rs

@@ -84,7 +84,10 @@ impl syn::parse::Parse for PalletStructAttr {
 			syn::parenthesized!(generate_content in content);
 			let vis = generate_content.parse::<syn::Visibility>()?;
 			generate_content.parse::<syn::Token![trait]>()?;
-			let keyword = generate_content.parse::<keyword::Store>()?;
+			let mut keyword = generate_content.parse::<keyword::Store>()?;
+			// set span of Store keyword same to attirbute macro `generate_store`
+			// so that deprecated warning highlights use of macro.
+			keyword.span = content.span();
 			Ok(Self::GenerateStore { vis, keyword, span })
 		} else if lookahead.peek(keyword::without_storage_info) {
 			let span = content.parse::<keyword::without_storage_info>()?.span();

frame/support/test/tests/pallet_ui/deprecated_store_attr.rs

@@ -1,24 +1,11 @@
 #[frame_support::pallet]
 mod pallet {
-	use frame_support::pallet_prelude::Hooks;
-	use frame_system::pallet_prelude::BlockNumberFor;
-	use frame_support::pallet_prelude::StorageValue;
-
 	#[pallet::config]
 	pub trait Config: frame_system::Config {}
 
 	#[pallet::pallet]
 	#[pallet::generate_store(trait Store)]
 	pub struct Pallet<T>(core::marker::PhantomData<T>);
-
-	#[pallet::hooks]
-	impl<T: Config> Hooks<BlockNumberFor<T>> for Pallet<T> {}
-
-	#[pallet::call]
-	impl<T: Config> Pallet<T> {}
-
-	#[pallet::storage]
-	type Foo<T> = StorageValue<_, u8>;
 }
 
 fn main() {}

frame/support/test/tests/pallet_ui/deprecated_store_attr.stderr

@@ -1,8 +1,8 @@
-error: use of deprecated trait `pallet::Store`: Use of #[pallet::generate_store(pub(super) trait Store)] will be removed soon.
+error: use of deprecated trait `pallet::Store`: Use of `#[pallet::generate_store(pub(super) trait Store)]` will be removed soon.
                Check https://github.com/paritytech/substrate/pull/13535 for more details.
-  --> $DIR/deprecated_store_attr.rs:11:33
-   |
-11 |     #[pallet::generate_store(trait Store)]
-   |                                    ^^^^^
-   |
-   = note: `-D deprecated` implied by `-D warnings`
+ --> tests/pallet_ui/deprecated_store_attr.rs:7:3
+  |
+7 |     #[pallet::generate_store(trait Store)]
+  |      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+  |
+  = note: `-D deprecated` implied by `-D warnings`

frame/support/test/tests/pallet_ui/store_trait_leak_private.stderr

@@ -1,17 +1,17 @@
-error: use of deprecated trait `pallet::Store`: Use of #[pallet::generate_store(pub(super) trait Store)] will be removed soon.
+error: use of deprecated trait `pallet::Store`: Use of `#[pallet::generate_store(pub(super) trait Store)]` will be removed soon.
                Check https://github.com/paritytech/substrate/pull/13535 for more details.
-  --> $DIR/store_trait_leak_private.rs:11:37
+  --> tests/pallet_ui/store_trait_leak_private.rs:11:3
    |
 11 |     #[pallet::generate_store(pub trait Store)]
-   |                                        ^^^^^
+   |      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: `-D deprecated` implied by `-D warnings`
 
 error[E0446]: private type `_GeneratedPrefixForStorageFoo<T>` in public interface
-  --> $DIR/store_trait_leak_private.rs:11:37
+  --> tests/pallet_ui/store_trait_leak_private.rs:11:3
    |
 11 |     #[pallet::generate_store(pub trait Store)]
-   |                                        ^^^^^ can't leak private type
+   |      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ can't leak private type
 ...
 20 |     #[pallet::storage]
    |               ------- `_GeneratedPrefixForStorageFoo<T>` declared as private