Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Update all weights #13614

Merged
ggwpez merged 2 commits into from
Mar 16, 2023
Merged

Update all weights #13614

ggwpez merged 2 commits into from
Mar 16, 2023

Conversation

@ggwpez
Copy link
Member

@ggwpez ggwpez commented Mar 15, 2023

Baseline for #13408

@ggwpez
Copy link
Member Author

ggwpez commented Mar 15, 2023

bot bench $ all

@athei athei force-pushed the oty-update-weights branch from 6112e9f to df9ed83 Compare March 15, 2023 22:06
@athei
Copy link
Member

athei commented Mar 15, 2023

bot clean
bot bench $ all

@command-bot
Copy link

command-bot bot commented Mar 15, 2023 •
edited
Loading

@athei https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2532437 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" all. Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 68-0e410779-be51-4938-aa46-615e03d6a998 to cancel this command or bot cancel to cancel all commands in this pull request.

@athei
Copy link
Member

athei commented Mar 15, 2023

The original commit did remove a weight file which made the compilation file. I just use an empty commit instead.

@command-bot
Copy link

command-bot bot commented Mar 16, 2023

@athei Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" all has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2532437 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2532437/artifacts/download.

@ggwpez ggwpez marked this pull request as ready for review March 16, 2023 11:43
@ggwpez ggwpez requested a review from a team March 16, 2023 11:43
@ggwpez ggwpez added A0-please_review Pull request needs code review. A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Mar 16, 2023
@athei
Copy link
Member

athei commented Mar 16, 2023

The failure of continuous-integration/gitlab-check-crate-publishing is unrelated to this PR, right?

sam0x17
sam0x17 approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@sam0x17 sam0x17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is indeed all weight changes 👍🏻
Screenshot 2023-03-16 at 12 56 12 PM

@ggwpez ggwpez merged commit be9e305 into master Mar 16, 2023
@ggwpez ggwpez deleted the oty-update-weights branch March 16, 2023 16:57
breathx pushed a commit to gear-tech/substrate that referenced this pull request Apr 22, 2023
@ggwpez @athei @breathx
Update all weights (paritytech#13614)
4bc6d2f 
* Empty commit

* ".git/.scripts/commands/bench/bench.sh" all

---------

Co-authored-by: Alexander Theißen <[email protected]>
Co-authored-by: command-bot <>
@kacperzuk-neti kacperzuk-neti mentioned this pull request Jun 23, 2023
Merged
15 tasks
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
@ggwpez @athei @nathanwhit
Update all weights (paritytech#13614)
f020c03 
* Empty commit

* ".git/.scripts/commands/bench/bench.sh" all

---------

Co-authored-by: Alexander Theißen <[email protected]>
Co-authored-by: command-bot <>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@sam0x17 sam0x17 sam0x17 approved these changes

@athei athei athei approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A0-please_review Pull request needs code review. A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ggwpez @athei @sam0x17