Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

fix/chain_head: Ensure correct events for finalized branch #13632

Merged
lexnv merged 8 commits into from
Mar 22, 2023
Merged

fix/chain_head: Ensure correct events for finalized branch #13632

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
12c3235
chain_head/follow: Ensure correct events for finalized branch
lexnv Mar 17, 2023
c6f9691
Merge remote-tracking branch 'origin/master' into lexnv/fix_chainhead…
lexnv Mar 17, 2023
df6a438
Reenable tests
lexnv Mar 17, 2023
5f4907b
Do some clean ups and add some more docs
bkchr Mar 21, 2023
d070b31
Merge remote-tracking branch 'origin/master' into lexnv/fix_chainhead…
bkchr Mar 21, 2023
26f2e8c
Fix gramatic
bkchr Mar 22, 2023
c56a02a
Update client/rpc-spec-v2/src/chain_head/chain_head_follow.rs
bkchr Mar 22, 2023
3d223a4
rpc/chain_head: Introduce error for absent headers
lexnv Mar 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update client/rpc-spec-v2/src/chain_head/chain_head_follow.rs 
Co-authored-by: Sebastian Kunert <[email protected]>
  • Loading branch information
@bkchr @skunert
bkchr and skunert authored Mar 22, 2023
commit c56a02a8a476144d8518a78d86f9a0c50fa8515f
2 changes: 1 addition & 1 deletion client/rpc-spec-v2/src/chain_head/chain_head_follow.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,7 @@ where
return Ok(Default::default())
};

// Find the parent hash.
// Find the parent header.
let Some(first_header) = self.client.header(*first_hash)? else {
return Err(SubscriptionManagementError::BlockHashAbsent)
Copy link
Contributor

@skunert skunert Mar 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super nit: This sounds like the block hash is absent, but its more HeaderNotFound or something.

Copy link
Contributor Author

@lexnv lexnv Mar 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense! I've changed it to BlockHeaderAbsent to make it explicit that we are missing the header from the db, thanks!

};
Expand Down