refactor: state RPC remove max_rpc_payload_size

[niklasad1]

Close #13623

This limit on state_traceBlock RPC is not needed anymore as the JSON-RPC servers doesn't terminate the connection if the RPC max limit is exceeded anymore

Until this PR is merged, it's also possible to run --rpc-max-payload <LIMIT> for the limit in the state RPC to work properly.

[koute]

It'd be nice to also add a deprecation message which pops up when the user specifies this argument on the command line.

[niklasad1]

We already got, sufficient?

      --rpc-max-payload <RPC_MAX_PAYLOAD>
          DEPRECATED, this has no affect anymore. Use `rpc_max_request_size` or `rpc_max_response_size` instead

However, it was a nit by me when I deprecated some of the RPC flags and missed e that just --rpc-max-payload was used by the this RPC method/tracing stuff.

[koute]

We already got, sufficient?

      --rpc-max-payload <RPC_MAX_PAYLOAD>
          DEPRECATED, this has no affect anymore. Use `rpc_max_request_size` or `rpc_max_response_size` instead

Does this pop up also when it's used, or do the user has to look at --help? Because if it's only in --help then no one's going to react to it. The idea here is to get people to remove this parameter from their command line invocations so that we can completely nuke it in a few releases.

[niklasad1]

☝️ is one --help indeed but I added some ugly warnings as well when it's used

DEPRECATED: `--rpc_max_payload` has been removed use `rpc-max-response-size or rpc-max-request-size` instead
Setting `rpc-max-response-size` to `max(rpc_max_payload, rpc_max_request_size)`
DEPRECATED: `--rpc_max_payload` has been removed use `rpc-max-response-size or rpc-max-request-size` instead
Setting HTTP `rpc-max-response-size` to `max(rpc_max_payload, rpc_max_response_size)`

[koute]

point_up is one --help indeed but I added some ugly warnings as well when it's used

DEPRECATED: `--rpc_max_payload` has been removed use `rpc-max-response-size or rpc-max-request-size` instead
Setting `rpc-max-response-size` to `max(rpc_max_payload, rpc_max_request_size)`
DEPRECATED: `--rpc_max_payload` has been removed use `rpc-max-response-size or rpc-max-request-size` instead
Setting HTTP `rpc-max-response-size` to `max(rpc_max_payload, rpc_max_response_size)`

Yeah, if there's an actual warning then that's fine by me. 👍

[niklasad1]

bot merge