Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

try-runtime: run migration checks per default #13684

Merged
paritytech-processbot merged 2 commits into from
Mar 24, 2023
Merged

try-runtime: run migration checks per default #13684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
844e9f6
try-runtime: run migration checks per default
ggwpez Mar 22, 2023
4590fff
Fix docs
ggwpez Mar 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions utils/frame/try-runtime/cli/src/commands/on_runtime_upgrade.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ pub struct OnRuntimeUpgradeCmd {
/// Performing any checks will potentially invalidate the measured PoV/Weight.
// NOTE: The clap attributes make it backwards compatible with the previous `--checks` flag.
#[clap(long,
default_value = "None",
default_missing_value = "All",
default_value = "pre-and-post",
default_missing_value = "all",
num_args = 0..=1,
require_equals = true,
verbatim_doc_comment)]
Expand Down
10 changes: 5 additions & 5 deletions utils/frame/try-runtime/cli/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,10 +134,10 @@
//!
//! ```ignore
//!
//! #[cfg(feature = try-runtime)]
//! #[cfg(feature = "try-runtime")]
//! fn pre_upgrade() -> Result<Vec<u8>, &'static str> {}
//!
//! #[cfg(feature = try-runtime)]
//! #[cfg(feature = "try-runtime")]
//! fn post_upgrade(state: Vec<u8>) -> Result<(), &'static str> {}
//! ```
//!
Expand All @@ -152,9 +152,9 @@
//!
//! Similarly, each pallet can expose a function in `#[pallet::hooks]` section as follows:
//!
//! ```
//! #[cfg(feature = try-runtime)]
//! fn try_state(_) -> Result<(), &'static str> {}
//! ```ignore
//! #[cfg(feature = "try-runtime")]
Copy link
Member Author

@ggwpez ggwpez Mar 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI did not catch this, but locally it failed when doing cargo test -p try-runtime-cli --features try-runtime.

//! fn try_state(_: BlockNumber) -> Result<(), &'static str> {}
//! ```
//!
//! which is called on numerous code paths in the try-runtime tool. These checks should ensure that
Expand Down