Implements `try_state` hook in elections and EPM pallets #13718

gpestana · 2023-03-27T09:11:57Z

This PR implements the try_state hook in elections and EPM pallets and uses it in the tests. An improvement to this PR would be to work on paritytech/polkadot-sdk#210 to automatically include calling the try_state hook in all tests.

Related to paritytech/polkadot-sdk#239

frame/election-provider-multi-phase/src/lib.rs

liamaharon · 2023-04-12T10:39:33Z

frame/election-provider-multi-phase/src/lib.rs

+	// [`Snapshot`] state check. Invariants:
+	// - [`DesiredTargets`] exist IFF [`Snapshot`] is present.
+	// - [`SnapshotMetadata`] exist IFF [`Snapshot`] is present.


Would it be more thorough to check this: if Snapshot or DesiredTargets or SnapshotMetadata exist, then they must all exist?

Otherwise this check would pass if we're in a weird state like only DesiredTargets is set but Snapshot and SnapshotMetadata are not

Added one more check to ensure DesiredTargets and SnapshotMetadata are not set if Snapshot is not set.

liamaharon · 2023-04-12T10:40:27Z

frame/election-provider-multi-phase/src/lib.rs

+
+	// [`SignedSubmissionsMap`] state check. Invariants:
+	// - All [`SignedSubmissionIndices`] are present in [`SignedSubmissionsMap`], and no more;
+	// - [`SignedSubmissionNextIndex`] is not present in [`SignedSubmissionsMap`];


I wonder if we can be more specific with this invariant. Should SignedSubmissionNextIndex be equal to the size of SignedSubmissionsMap?

Should SignedSubmissionNextIndex be equal to the size of SignedSubmissionsMap?

Not necessarily, that is the reason why we keep the index in storage (also to avoid iterating over the map).

frame/election-provider-multi-phase/src/lib.rs

frame/elections-phragmen/src/lib.rs

Co-authored-by: Liam Aharon <[email protected]>

* chore(sc-cli): improve runner and signals * Update client/cli/src/runner.rs * fmt --------- Co-authored-by: Bastian Köcher <[email protected]>

as requested in https://github.com/paritytech/ci_cd/issues/761

* Fix the Referenda confirming alarm * Add minimal regression test This fails on bf395c8 since the downwards rounding voids the curve delay. Signed-off-by: Oliver Tale-Yazdi <[email protected]> --------- Signed-off-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: Oliver Tale-Yazdi <[email protected]>

* reward pool migration fix * comment * remove generic * rm max * foramtting * Add note to V4 migration Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Add more asserts to the V5 migration Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Make compile Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Update frame/nomination-pools/src/migration.rs Co-authored-by: Gonçalo Pestana <[email protected]> * Make V4 migration re-usable Otherwise it wont chain together with the V5. Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Add MigrateV3ToV5 wrapper Signed-off-by: Oliver Tale-Yazdi <[email protected]> --------- Signed-off-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: Gonçalo Pestana <[email protected]>

* Change node-template license from Unlicense to MIT-0 * Change frame examples license from Unlicense to MIT-0 * Update bin/node-template/LICENSE --------- Co-authored-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: parity-processbot <>

* updating labels descriptions * delete milestones * Update docs/CONTRIBUTING.adoc Co-authored-by: Bastian Köcher <[email protected]> * link to label docs * Update docs/CONTRIBUTING.adoc Co-authored-by: Oliver Tale-Yazdi <[email protected]> --------- Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: parity-processbot <> Co-authored-by: Oliver Tale-Yazdi <[email protected]>

…orker (#13730) * Remove `HeaderBackend` requirement from `NetworkWorker` * Remove HeaderBackend from authority-discovery

Co-authored-by: parity-processbot <>

* refactor: inconsistent BalanceConversion fn * Revert "refactor: inconsistent BalanceConversion fn" This reverts commit 1177877. * refactor: rename BalanceConversion trait * feat: add ConversionFromAssetBalance

This removes the deprecated batch verification. This was actually never really activated. Nevertheless, we need to keep the host functions around to support old runtimes which may import these host functions. However, we do not give access to these functions anymore. This means that any new runtime can not call them anymore. The host function implementations we keep will not do batch verification and will instead fall back to the always existing option of directly verifying the passed signature. `finish_batch_verification` will return the combined result of all the batch verify calls. This removes the `TaskExecutorExt` which only existed to support the batch verification. So, any code that used this extension can just remove the registration of them. It also removes `SignatureBatching` that was used by `frame-executive` to control the batch verification. However, there wasn't any `Verify` implementation that called the batch verification functions.

* Use proc-macro-warning crate Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Fixup Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Fix pallet_ui tests Also renamed some of the odd-named ones. Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Update dep Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Ignore hardcoded weight warning To be fixed in https://github.com/paritytech/substrate/issues/13813 Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Fix test pallet Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Fix more tests Signed-off-by: Oliver Tale-Yazdi <[email protected]> --------- Signed-off-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: parity-processbot <>

…es to collections and items in the Uniques pallet in order to follow the commonly accepted NFTs terminology.) (#13322) * Update documentation for uniques The documentation was outdated after merge of #11389 Using the widely spread term collections and item instead of the previous class and instance. * Update README.md --------- Co-authored-by: Jegor Sidorenko <[email protected]> Co-authored-by: Jegor Sidorenko <[email protected]>

* Implement #[pallet::hold_reason] * Appease clippy * cargo fmt * Update test expectations * Update test expectations * Support composite_enum attribute instead * Update test expectations * Change hold_reason to composite_enum * Add UI test for unsupported identifier when using composite_enum * Fix comment * Add documentation for pallet::composable_enum * More docs * cargo fmt

* Expose WASM extensions in executor semantics * Fix benches * Remove redundant extensions

* Remove deprecated pallet calls Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Deprecate old weight Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Update Runtime API Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Fix tests Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Delete shitty code Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Fix doctest Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Update frame/alliance/src/lib.rs Co-authored-by: Koute <[email protected]> * Add doc Signed-off-by: Oliver Tale-Yazdi <[email protected]> * contracts: Use u64 as old weight type Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Update frame/contracts/src/lib.rs Co-authored-by: Alexander Theißen <[email protected]> --------- Signed-off-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: Koute <[email protected]> Co-authored-by: Alexander Theißen <[email protected]> Co-authored-by: parity-processbot <>

…13820) Instead of registering `ReadRuntimeVersionExt` in `sp-state-machine` it is moved to `ExecutionExtension` which provides the default extensions.

* Adds on_idle round-robin logic to trait Hooks docs * Makes the docs more concise * Update frame/support/src/traits/hooks.rs Co-authored-by: Bastian Köcher <[email protected]> * fmt --------- Co-authored-by: Bastian Köcher <[email protected]>

* TrieRecorder: Start adding support for transactions * Adds `transactions` functions and some test * More tests * Docs * Ensure that we rollback failed transactions in the storage proof * FMT * Update primitives/trie/src/recorder.rs Co-authored-by: Dmitry Markin <[email protected]> * Review comments * Update primitives/trie/src/recorder.rs Co-authored-by: Sebastian Kunert <[email protected]> * ".git/.scripts/commands/fmt/fmt.sh" * For the holy clippy! * Update primitives/trie/src/recorder.rs Co-authored-by: Anton <[email protected]> --------- Co-authored-by: Dmitry Markin <[email protected]> Co-authored-by: Sebastian Kunert <[email protected]> Co-authored-by: command-bot <> Co-authored-by: Anton <[email protected]>

* Add HoldReason to the NIS pallet * Rename composable_enum to composite_enum * Add encoding test * Add more doc comments

…test utils (#13794) * new test for try-runtime tuple stuff * fix * remove development comment * formatting * remove todo comment * follow-chain working test * refactor common cli testing utils * fix comment * revert Cargo.lock changes * update Cargo.lock * improve doc comment * fix error typo * update Cargo.lock * feature gate try-runtime test * build_substrate cli test util * feature gate follow_chain tests * move fn start_node to test-utils * improve test pkg name * use tokio Child and Command * remove redundant import * fix ci * fix ci * don't leave hanging processes * improved child process cleanup * use existing KillChildOnDrop * remove redundant comment * Update test-utils/cli/src/lib.rs Co-authored-by: Koute <[email protected]> --------- Co-authored-by: kianenigma <[email protected]> Co-authored-by: Koute <[email protected]>

* benchmarking to generate weights file * add the calculated weights in the extrinsics * use benchmarking v2 syntax to generate the weights * minor syntax change when benchmarking * added WeightInfo in the mock to pass tests * minor cargo fmt format changes

paritytech-cicd-pr · 2023-04-23T15:47:38Z

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-benches
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2718018

gpestana · 2023-04-23T15:48:46Z

bot rebase

paritytech-processbot · 2023-04-23T15:48:52Z

Branch is already up-to-date

gpestana · 2023-04-23T16:00:55Z

Closing in lieu of #13979

Adds try_state to elections pallet

0402ecc

gpestana requested a review from a team March 27, 2023 09:11

gpestana self-assigned this Mar 27, 2023

gpestana marked this pull request as draft March 27, 2023 09:12

Finishes elections try-state hook; starts EPM hook impl

af0e6a5

gpestana changed the title ~~(wip) Implements try_state hook in elections pallet~~ (wip) Implements try_state hook in elections and EPM pallets Mar 28, 2023

gpestana added 2 commits March 28, 2023 22:29

Adds scaffolding for EPM try_state checks

788ddf4

implements checks for EPM

b721463

gpestana marked this pull request as ready for review March 30, 2023 16:10

gpestana added the D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit label Mar 30, 2023

gpestana changed the title ~~(wip) Implements try_state hook in elections and EPM pallets~~ Implements try_state hook in elections and EPM pallets Mar 30, 2023

liamaharon reviewed Apr 12, 2023

View reviewed changes

gpestana and others added 13 commits April 20, 2023 16:24

Update frame/election-provider-multi-phase/src/lib.rs

3103262

Co-authored-by: Liam Aharon <[email protected]>

Update frame/elections-phragmen/src/lib.rs

6cbf9ab

Co-authored-by: Liam Aharon <[email protected]>

chore(sc-cli): improve runner and signals (#13688)

a483470

* chore(sc-cli): improve runner and signals * Update client/cli/src/runner.rs * fmt --------- Co-authored-by: Bastian Köcher <[email protected]>

add a new ci job to fuzz sp-arithmetic (#13673)

8077b19

as requested in https://github.com/paritytech/ci_cd/issues/761

sc-slots: Forward block size limit (#13716)

19e9edc

Update pallet licenses to Apache-2.0 (#13467)

c04f812

contracts: Add host function tracing (#13648)

f94fce0

CI: Investigate why RUSTFLAGS differs on master and PRs (#13686)

9522b75

Remove HeaderBackend requirement from AuthorityDiscovery and NetworkW…

998d768

…orker (#13730) * Remove `HeaderBackend` requirement from `NetworkWorker` * Remove HeaderBackend from authority-discovery

muharem and others added 18 commits April 20, 2023 17:27

Scheduler pre block limit note (#13231)

a066028

Co-authored-by: parity-processbot <>

Disable sign-ext WASM feature when building runtimes (#13804)

6d38833

Co-authored-by: parity-processbot <>

refactor: inconsistent BalanceConversion fn (#13610)

71eaef9

* refactor: inconsistent BalanceConversion fn * Revert "refactor: inconsistent BalanceConversion fn" This reverts commit 1177877. * refactor: rename BalanceConversion trait * feat: add ConversionFromAssetBalance

Expose WASM extensions in executor semantics (#13811)

f6f7ced

* Expose WASM extensions in executor semantics * Fix benches * Remove redundant extensions

update links to ink! (#13819)

32f601b

Move registration of ReadRuntimeVersionExt to ExecutionExtension (#…

d1e309f

…13820) Instead of registering `ReadRuntimeVersionExt` in `sp-state-machine` it is moved to `ExecutionExtension` which provides the default extensions.

remove duplicate sync option documentation (#13828)

a98e3c2

Add HoldReason to the NIS pallet (#13823)

74c0cf6

* Add HoldReason to the NIS pallet * Rename composable_enum to composite_enum * Add encoding test * Add more doc comments

Addresses PR review comments

359d86d

gpestana requested review from a team, andresilva, athei and koute as code owners April 23, 2023 15:45

Merge branch 'master' into gpestana/try_state_elections

c6633c8

gpestana marked this pull request as draft April 23, 2023 15:49

gpestana mentioned this pull request Apr 23, 2023

Implements try_state hook in elections and EPM pallets #13979

Merged

gpestana closed this Apr 23, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Implements `try_state` hook in elections and EPM pallets #13718

Implements `try_state` hook in elections and EPM pallets #13718

Uh oh!

gpestana commented Mar 27, 2023 •

edited

Loading

Uh oh!

Uh oh!

liamaharon Apr 12, 2023

Uh oh!

gpestana Apr 23, 2023

Uh oh!

liamaharon Apr 12, 2023 •

edited

Loading

Uh oh!

gpestana Apr 23, 2023 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

paritytech-cicd-pr commented Apr 23, 2023

Uh oh!

gpestana commented Apr 23, 2023

Uh oh!

paritytech-processbot bot commented Apr 23, 2023

Uh oh!

gpestana commented Apr 23, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Implements try_state hook in elections and EPM pallets #13718

Implements try_state hook in elections and EPM pallets #13718

Uh oh!

Conversation

gpestana commented Mar 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

liamaharon Apr 12, 2023

Choose a reason for hiding this comment

Uh oh!

gpestana Apr 23, 2023

Choose a reason for hiding this comment

Uh oh!

liamaharon Apr 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gpestana Apr 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

paritytech-cicd-pr commented Apr 23, 2023

Uh oh!

gpestana commented Apr 23, 2023

Uh oh!

paritytech-processbot bot commented Apr 23, 2023

Uh oh!

gpestana commented Apr 23, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Implements `try_state` hook in elections and EPM pallets #13718

Implements `try_state` hook in elections and EPM pallets #13718

gpestana commented Mar 27, 2023 •

edited

Loading

liamaharon Apr 12, 2023 •

edited

Loading

gpestana Apr 23, 2023 •

edited

Loading