This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Application Crypto cleanup #13746
Merged
Application Crypto cleanup #13746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davxy
added
A0-please_review
michalkucharczyk
approved these changes
Mar 29, 2023
Contributor
michalkucharczyk
left a comment
michalkucharczyk
left a comment
There was a problem hiding this comment.
lgtm. Out of curiosity - why did you remove MaybeHash? Is this because it was not used anywhere? Or maybe it was to restrictive for some type that will be used in this context in future?
Member
Author
Because I'm dumb 🤦♂️ |
Contributor
|
This needs to be rebased on current master, there have been breaking changes to the check-crate-publishing job. |
Co-authored-by: Anton <[email protected]>
skunert
approved these changes
Mar 30, 2023
pgherveou
pushed a commit
that referenced
this pull request
Apr 4, 2023
* Adjust application crypto docs * Blanket implementation for 'RuntimeAppPublic' trait * Blanket implementation for 'BoundToRuntimeAppPublic' for 'RuntimeAppPublic' * Relax type bounds * Docs fix * restore MaybeHash * Commit suggestion Co-authored-by: Anton <[email protected]> --------- Co-authored-by: Anton <[email protected]>
gpestana
pushed a commit
that referenced
this pull request
Apr 23, 2023
* Adjust application crypto docs * Blanket implementation for 'RuntimeAppPublic' trait * Blanket implementation for 'BoundToRuntimeAppPublic' for 'RuntimeAppPublic' * Relax type bounds * Docs fix * restore MaybeHash * Commit suggestion Co-authored-by: Anton <[email protected]> --------- Co-authored-by: Anton <[email protected]>
15 tasks
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
* Adjust application crypto docs * Blanket implementation for 'RuntimeAppPublic' trait * Blanket implementation for 'BoundToRuntimeAppPublic' for 'RuntimeAppPublic' * Relax type bounds * Docs fix * restore MaybeHash * Commit suggestion Co-authored-by: Anton <[email protected]> --------- Co-authored-by: Anton <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blanket implementation of
RuntimeAppPublictrait for any type implementingAppPublicand for whichAppPubic::GenericimplementsRuntimePublic(in practice implements the trait for any application-specificPublicthat can be used within the runtime).app_crypto!allows to use the macro to implement application specific crypto types that are not necessarily usable by the runtime.Blanket implementation of
BoundToRuntimeAppPublictrait for any type implementingRuntimeAppPublicRemove unused
CRYPTO_IDfromRuntimeAppPublicDocumentation improvement
Relax some trait bounds