fix try-runtime fast-forward when run from the substrate cli and add test
#13888
Conversation
liamaharon
added
A0-please_review
liamaharon
changed the title
try-runtime fast-forward when run from the substrate clitry-runtime fast-forward when run from the substrate cli and add test
| pub fn start_node() -> Child { | ||
| Command::new(cargo_bin("substrate")) | ||
| Command::new(cargo_bin("node-template")) | ||
| .stdout(process::Stdio::piped()) | ||
| .stderr(process::Stdio::piped()) | ||
| .args(&["--dev", "--tmp", "--ws-port=45789", "--no-hardware-benchmarks"]) | ||
| .args(&["--dev", "--ws-port=45789"]) | ||
| .spawn() | ||
| .unwrap() |
There was a problem hiding this comment.
Just to make things simpler.
--dev makes --tmp redundant, and node-template doesn't run any hardware benchmarks by default.
Let me know if I'm missing something though.
Co-authored-by: Bastian Köcher <[email protected]>
Co-authored-by: Bastian Köcher <[email protected]>
|
I'm converting this PR back to a draft with the intention of getting |
liamaharon
added
A3-in_progress
| use std::sync::Arc; | ||
|
|
||
| #[cfg(feature = "try-runtime")] | ||
| use try_runtime_cli::block_building_info::timestamp_with_aura_info; |
There was a problem hiding this comment.
I personally always prefer using the full path where needed, or doing the import more locally, rather than feature gated imports, but up to you.
|
Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Closing this for now, need to solve issue with per-chain inherents first. |
Closes: #13831
Description
fast-forwardrequires a customBlockBuildingInfoProviderwith the blocktime set (see discussion here #12896).The custom provider had been set for the
node-templatecli, but not thesubstratecli.BlockBuildingInfoProviderwith thesubstrateclinode-template,substrate,polkadot,kusamafollow-chainexits with a success status code, and perform a basic check on the output