Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Conversation

@muharem
Copy link
Contributor

@muharem muharem commented Apr 13, 2023

Votes and delegations should lock for all reasons except RESERVE.

The changes do not change anything for clients who uses the latest version of balances pallet (Currency and fungibles from it). Since those implementations ignore the reason.

@muharem muharem added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Apr 13, 2023
@muharem muharem changed the title Vote locks for tipping Vote locks tipping Apr 14, 2023
@muharem muharem requested a review from joepetrowski April 14, 2023 11:07
@muharem muharem added D9-needsaudit 👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited and removed D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Apr 18, 2023
@jakoblell jakoblell added D1-audited 👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited and removed D9-needsaudit 👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited labels Apr 24, 2023
@muharem muharem requested a review from ggwpez April 24, 2023 12:35
@muharem muharem changed the title Vote locks tipping Vote locks for all reasons except RESERVE Apr 24, 2023
@muharem
Copy link
Contributor Author

muharem commented Apr 24, 2023

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot
Copy link

Merge cancelled due to error. Error: Statuses failed for 03d3fd2

@muharem
Copy link
Contributor Author

muharem commented Apr 24, 2023

bot rebase

@paritytech-processbot
Copy link

Rebased

@muharem
Copy link
Contributor Author

muharem commented Apr 24, 2023

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 910bafb into master Apr 24, 2023
@paritytech-processbot paritytech-processbot bot deleted the muharem-voting-lock-tips branch April 24, 2023 14:57
gpestana pushed a commit that referenced this pull request May 4, 2023
* Vote locks tip

* except reserve

* reason for delegate

* fix tests

---------

Co-authored-by: parity-processbot <>
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
* Vote locks tip

* except reserve

* reason for delegate

* fix tests

---------

Co-authored-by: parity-processbot <>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D1-audited 👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants