Review fixes

Co-authored-by: Sam Johnson <[email protected]>

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

frame/support/procedural/src/pallet/expand/call.rs

@@ -80,11 +80,9 @@ pub fn expand_call(def: &mut Def) -> proc_macro2::TokenStream {
 
 	let mut fn_weight = Vec::<TokenStream2>::new();
 	let mut weight_warnings = Vec::new();
-	for method in methods.iter() {
+	for method in &methods {
 		match &method.weight {
-			CallWeightDef::DevModeDefault => {
-				fn_weight.push(syn::parse_quote!(0));
-			},
+			CallWeightDef::DevModeDefault => fn_weight.push(syn::parse_quote!(0)),
 			CallWeightDef::Immediate(e @ syn::Expr::Lit(lit)) if !def.dev_mode => {
 				let warning = proc_macro_warning::Warning::new_deprecated("ConstantWeight")
 					.index(weight_warnings.len())

frame/support/procedural/src/pallet/parse/call.rs

@@ -251,7 +251,9 @@ impl CallDef {
 					0 if dev_mode => CallWeightDef::DevModeDefault,
 					0 => return Err(syn::Error::new(
 						method.sig.span(),
-						"A pallet::call requires either a concrete `#[pallet::weight($expr)]` or an inherited weight from the `#[pallet:call(weight($type))]` attribute, but none were given.",
+						"A pallet::call requires either a concrete `#[pallet::weight($expr)]` or an 
+						inherited weight from the `#[pallet:call(weight($type))]` attribute, but 
+						none were given.",
 					)),
 					1 => match weight_attrs.pop().unwrap() {
 						FunctionAttr::Weight(w) => CallWeightDef::Immediate(w),