This repository was archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Adds example for dev_mode and updates doc #13944
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
05516b2
Adds example for dev_mode and updates doc
gupnik e7b05c5
Addresses review comments
gupnik 8c7ce06
Update frame/examples/dev-mode/src/lib.rs
gupnik a145b7a
Addresses review comment
gupnik f1e0f43
Merge branch 'gupnik/optional_hashers_doc' of github.com:paritytech/s…
gupnik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| [package] | ||
| name = "pallet-dev-mode" | ||
| version = "4.0.0-dev" | ||
| authors = ["Parity Technologies <[email protected]>"] | ||
| edition = "2021" | ||
| license = "MIT-0" | ||
| homepage = "https://substrate.io" | ||
| repository = "https://github.com/paritytech/substrate/" | ||
| description = "FRAME example pallet" | ||
| readme = "README.md" | ||
|
|
||
| [package.metadata.docs.rs] | ||
| targets = ["x86_64-unknown-linux-gnu"] | ||
|
|
||
| [dependencies] | ||
| codec = { package = "parity-scale-codec", version = "3.2.2", default-features = false } | ||
| log = { version = "0.4.17", default-features = false } | ||
| scale-info = { version = "2.5.0", default-features = false, features = ["derive"] } | ||
| frame-support = { version = "4.0.0-dev", default-features = false, path = "../../support" } | ||
| frame-system = { version = "4.0.0-dev", default-features = false, path = "../../system" } | ||
| pallet-balances = { version = "4.0.0-dev", default-features = false, path = "../../balances" } | ||
| sp-io = { version = "7.0.0", default-features = false, path = "../../../primitives/io" } | ||
| sp-runtime = { version = "7.0.0", default-features = false, path = "../../../primitives/runtime" } | ||
| sp-std = { version = "5.0.0", default-features = false, path = "../../../primitives/std" } | ||
|
|
||
| [dev-dependencies] | ||
| sp-core = { version = "7.0.0", default-features = false, path = "../../../primitives/core" } | ||
|
|
||
| [features] | ||
| default = ["std"] | ||
| std = [ | ||
| "codec/std", | ||
| "frame-support/std", | ||
| "frame-system/std", | ||
| "log/std", | ||
| "pallet-balances/std", | ||
| "scale-info/std", | ||
| "sp-io/std", | ||
| "sp-runtime/std", | ||
| "sp-std/std", | ||
| ] | ||
| try-runtime = ["frame-support/try-runtime"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| <!-- markdown-link-check-disable --> | ||
| # Dev Mode Example Pallet | ||
|
|
||
| A simple example of a FRAME pallet demonstrating | ||
| the ease of requirements for a pallet in dev mode. | ||
|
|
||
| Run `cargo doc --package pallet-dev-mode --open` to view this pallet's documentation. | ||
|
|
||
| **Dev mode is not meant to be used in production.** | ||
|
|
||
| License: MIT-0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,118 @@ | ||
| // This file is part of Substrate. | ||
|
|
||
| // Copyright (C) Parity Technologies (UK) Ltd. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| //! <!-- markdown-link-check-disable --> | ||
| //! # Dev Mode Example Pallet | ||
| //! | ||
| //! A simple example of a FRAME pallet demonstrating | ||
| //! the ease of requirements for a pallet in dev mode. | ||
| //! | ||
| //! Run `cargo doc --package pallet-dev-mode --open` to view this pallet's documentation. | ||
| //! | ||
| //! **Dev mode is not meant to be used in production.** | ||
|
|
||
| // Ensure we're `no_std` when compiling for Wasm. | ||
| #![cfg_attr(not(feature = "std"), no_std)] | ||
|
|
||
| use frame_support::dispatch::DispatchResult; | ||
| use frame_system::ensure_signed; | ||
|
|
||
| // Re-export pallet items so that they can be accessed from the crate namespace. | ||
| pub use pallet::*; | ||
|
|
||
| #[cfg(test)] | ||
| mod tests; | ||
|
|
||
| /// A type alias for the balance type from this pallet's point of view. | ||
| type BalanceOf<T> = <T as pallet_balances::Config>::Balance; | ||
|
|
||
| /// Enable `dev_mode` for this pallet. | ||
| #[frame_support::pallet(dev_mode)] | ||
| pub mod pallet { | ||
| use super::*; | ||
| use frame_support::pallet_prelude::*; | ||
| use frame_system::pallet_prelude::*; | ||
|
|
||
| #[pallet::config] | ||
| pub trait Config: pallet_balances::Config + frame_system::Config { | ||
| /// The overarching event type. | ||
| type RuntimeEvent: From<Event<Self>> + IsType<<Self as frame_system::Config>::RuntimeEvent>; | ||
| } | ||
|
|
||
| // Simple declaration of the `Pallet` type. It is placeholder we use to implement traits and | ||
| // method. | ||
| #[pallet::pallet] | ||
| pub struct Pallet<T>(_); | ||
|
|
||
| #[pallet::call] | ||
| impl<T: Config> Pallet<T> { | ||
| #[pallet::call_index(0)] | ||
| /// No need to define a `weight` attribute here because of `dev_mode`. | ||
| pub fn add_dummy(origin: OriginFor<T>, id: T::AccountId) -> DispatchResult { | ||
| ensure_root(origin)?; | ||
|
|
||
| if let Some(mut dummies) = Dummy::<T>::get() { | ||
| dummies.push(id.clone()); | ||
| Dummy::<T>::set(Some(dummies)); | ||
| } else { | ||
| Dummy::<T>::set(Some(vec![id.clone()])); | ||
| } | ||
|
|
||
| // Let's deposit an event to let the outside world know this happened. | ||
| Self::deposit_event(Event::AddDummy { account: id }); | ||
|
|
||
| Ok(()) | ||
| } | ||
|
|
||
| #[pallet::call_index(1)] | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think making this optional is also a clear good next step for dev-mode 👍 |
||
| /// No need to define a `weight` attribute here because of `dev_mode`. | ||
| pub fn set_bar( | ||
| origin: OriginFor<T>, | ||
| #[pallet::compact] new_value: T::Balance, | ||
| ) -> DispatchResult { | ||
| let sender = ensure_signed(origin)?; | ||
|
|
||
| // Put the new value into storage. | ||
| <Bar<T>>::insert(&sender, new_value); | ||
|
|
||
| Self::deposit_event(Event::SetBar { account: sender, balance: new_value }); | ||
|
|
||
| Ok(()) | ||
| } | ||
| } | ||
|
|
||
| #[pallet::event] | ||
| #[pallet::generate_deposit(pub(super) fn deposit_event)] | ||
| pub enum Event<T: Config> { | ||
| AddDummy { account: T::AccountId }, | ||
| SetBar { account: T::AccountId, balance: BalanceOf<T> }, | ||
| } | ||
|
|
||
| /// The MEL requirement for bounded pallets is skipped by `dev_mode`. | ||
| /// This means that all storages are marked as unbounded. | ||
| /// This is equivalent to specifying `#[pallet::unbounded]` on this type definitions. | ||
| /// When the dev_mode is removed, we would need to implement implement `MaxEncodedLen`. | ||
| #[pallet::storage] | ||
| pub type Dummy<T: Config> = StorageValue<_, Vec<T::AccountId>>; | ||
|
|
||
| /// The Hasher requirement is skipped by `dev_mode`. So, second parameter can be `_` | ||
| /// and `Blake2_128Concat` is used as a default. | ||
| /// When the dev_mode is removed, we would need to specify the hasher like so: | ||
| /// `pub type Bar<T: Config> = StorageMap<_, Blake2_128Concat, T::AccountId, T::Balance>;`. | ||
| #[pallet::storage] | ||
| pub type Bar<T: Config> = StorageMap<_, _, T::AccountId, T::Balance>; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,130 @@ | ||
| // This file is part of Substrate. | ||
|
|
||
| // Copyright (C) Parity Technologies (UK) Ltd. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| //! Tests for pallet-dev-mode. | ||
|
|
||
| use crate::*; | ||
| use frame_support::{assert_ok, traits::ConstU64}; | ||
| use sp_core::H256; | ||
| use sp_runtime::{ | ||
| testing::Header, | ||
| traits::{BlakeTwo256, IdentityLookup}, | ||
| BuildStorage, | ||
| }; | ||
| // Reexport crate as its pallet name for construct_runtime. | ||
| use crate as pallet_dev_mode; | ||
|
|
||
| type UncheckedExtrinsic = frame_system::mocking::MockUncheckedExtrinsic<Test>; | ||
| type Block = frame_system::mocking::MockBlock<Test>; | ||
|
|
||
| // For testing the pallet, we construct a mock runtime. | ||
| frame_support::construct_runtime!( | ||
| pub enum Test where | ||
| Block = Block, | ||
| NodeBlock = Block, | ||
| UncheckedExtrinsic = UncheckedExtrinsic, | ||
| { | ||
| System: frame_system::{Pallet, Call, Config, Storage, Event<T>}, | ||
| Balances: pallet_balances::{Pallet, Call, Storage, Config<T>, Event<T>}, | ||
| Example: pallet_dev_mode::{Pallet, Call, Storage, Event<T>}, | ||
| } | ||
| ); | ||
|
|
||
| impl frame_system::Config for Test { | ||
| type BaseCallFilter = frame_support::traits::Everything; | ||
| type BlockWeights = (); | ||
| type BlockLength = (); | ||
| type DbWeight = (); | ||
| type RuntimeOrigin = RuntimeOrigin; | ||
| type Index = u64; | ||
| type BlockNumber = u64; | ||
| type Hash = H256; | ||
| type RuntimeCall = RuntimeCall; | ||
| type Hashing = BlakeTwo256; | ||
| type AccountId = u64; | ||
| type Lookup = IdentityLookup<Self::AccountId>; | ||
| type Header = Header; | ||
| type RuntimeEvent = RuntimeEvent; | ||
| type BlockHashCount = ConstU64<250>; | ||
| type Version = (); | ||
| type PalletInfo = PalletInfo; | ||
| type AccountData = pallet_balances::AccountData<u64>; | ||
| type OnNewAccount = (); | ||
| type OnKilledAccount = (); | ||
| type SystemWeightInfo = (); | ||
| type SS58Prefix = (); | ||
| type OnSetCode = (); | ||
| type MaxConsumers = frame_support::traits::ConstU32<16>; | ||
| } | ||
|
|
||
| impl pallet_balances::Config for Test { | ||
| type MaxLocks = (); | ||
| type MaxReserves = (); | ||
| type ReserveIdentifier = [u8; 8]; | ||
| type Balance = u64; | ||
| type DustRemoval = (); | ||
| type RuntimeEvent = RuntimeEvent; | ||
| type ExistentialDeposit = ConstU64<1>; | ||
| type AccountStore = System; | ||
| type WeightInfo = (); | ||
| type FreezeIdentifier = (); | ||
| type MaxFreezes = (); | ||
| type HoldIdentifier = (); | ||
| type MaxHolds = (); | ||
| } | ||
|
|
||
| impl Config for Test { | ||
| type RuntimeEvent = RuntimeEvent; | ||
| } | ||
|
|
||
| // This function basically just builds a genesis storage key/value store according to | ||
| // our desired mockup. | ||
| pub fn new_test_ext() -> sp_io::TestExternalities { | ||
| let t = GenesisConfig { | ||
| // We use default for brevity, but you can configure as desired if needed. | ||
| system: Default::default(), | ||
| balances: Default::default(), | ||
| } | ||
| .build_storage() | ||
| .unwrap(); | ||
| t.into() | ||
| } | ||
|
|
||
| #[test] | ||
| fn it_works_for_optional_value() { | ||
| new_test_ext().execute_with(|| { | ||
| assert_eq!(Dummy::<Test>::get(), None); | ||
|
|
||
| let val1 = 42; | ||
| assert_ok!(Example::add_dummy(RuntimeOrigin::root(), val1)); | ||
| assert_eq!(Dummy::<Test>::get(), Some(vec![val1])); | ||
|
|
||
| // Check that accumulate works when we have Some value in Dummy already. | ||
| let val2 = 27; | ||
| assert_ok!(Example::add_dummy(RuntimeOrigin::root(), val2)); | ||
| assert_eq!(Dummy::<Test>::get(), Some(vec![val1, val2])); | ||
| }); | ||
| } | ||
|
|
||
| #[test] | ||
| fn set_dummy_works() { | ||
| new_test_ext().execute_with(|| { | ||
| let test_val = 133; | ||
| assert_ok!(Example::set_bar(RuntimeOrigin::signed(1), test_val.into())); | ||
| assert_eq!(Bar::<Test>::get(1), Some(test_val)); | ||
| }); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.