This repository was archived by the owner on Nov 15, 2023. It is now read-only.
try-runtime-cli: improve ci stability #14030
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y-runtime-ci-stability
…y-runtime-ci-stability-improvements
niklasad1
approved these changes
Apr 27, 2023
Contributor
niklasad1
left a comment
niklasad1
left a comment
There was a problem hiding this comment.
Looks good to me
It would be safer to create a new HttpClient in each thread spawned in the "remote externalities" than to limit the number of threads, fine for now
liamaharon
added
A0-please_review
Contributor
Author
Yup I was considering this but it seems like it would require a larger refactor. We'll be doing a large refactor later anyway for lazy-download, and CI seems happy with this configuration, so decided not to do it here. |
gpestana
pushed a commit
that referenced
this pull request
May 4, 2023
* hardcode 1 thread * ci stability * fix comment * improve comment * kick ci * kick ci * update expect message * improve comment * kick ci * kick ci * configure threads with env var * fix threads env var * fix threads env var
15 tasks
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
* hardcode 1 thread * ci stability * fix comment * improve comment * kick ci * kick ci * update expect message * improve comment * kick ci * kick ci * configure threads with env var * fix threads env var * fix threads env var
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HttpClientBuilderconfig to fix some stability issues with the CI and increase the max possible batch sizeHttpClient("dispatch dropped without returning error" when using Client from tests hyperium/hyper#2112)the on_chain version is equal or more than the current one. I guess we need to update its Migrations struct? If so, I'm happy to handle that in a seperate PR.Closes #14013 and #14006