truly optional rocksdb

[drahnr]

What does it do?

Currently the sc-client-db is pulled in with default features at the level cli which makes it a defacto dependency for all parachains. With the latest slew of compiler releases not include <cstdint> by default anymore, and rocksdb binding a significant amount of CI resources, I felt it was time to get rid of it without having to continually patch substrate.

What important points should reviewers know?

RocksDB is now optional two levels further up, behind another rocksdb feature flag defaulting to on. The default behavior should not have changed.

Is there something left for follow-up PRs?

node-testing makes some assumptions of having some identifiers around which are not upheld, it surfaced when testing no-default-features, but otherwise no change.

---

We are successfully using this with polkadot-v0.9.41 (plus a few patches) and clang-16 and gcc-13.

[niklasad1]

bot rebase

[paritytech-processbot]

Rebased

[niklasad1]

nice, looks good

[drahnr]

Are the cumulus and polkadot CI checks caused by the changeset or are they known issues?

Could I get another review :)

[niklasad1]

bot rebase

[paritytech-processbot]

Rebased

[niklasad1]

Are the cumulus and polkadot CI checks caused by the changeset or are they known issues?

It's probably just because there were a bunch PRs merged recently that broke that, rebased the branch and it's seems to be okay but cumulus is currently broken because paritytech/cumulus#2574

So nothing to worry about

[bkchr]

and rocksdb binding a significant amount of CI resources

ROCKSDB_LIB_DIR="${rocksdb}/lib"; solves this problem.

And why are you using node-cli in your parachain?

[drahnr]

and rocksdb binding a significant amount of CI resources

ROCKSDB_LIB_DIR="${rocksdb}/lib"; solves this problem.

I am aware, which was my first quarrel with it. Now we had the gcc/clang update as part of our build container and again rocksdb made em all red. On the other handside, not all prebuilts can be linked with rocksdb due to missing symbols and friends. Time not worth spending, hence the radical option of cutting it out entirely.

And why are you using node-cli in your parachain?

We are not. sc-cli and sc-client are used, let me double check if the other changes are already part of master and were just missing in the 0.9.4x branch we use.