Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Add review rules regarding the owned files #14122

Merged
paritytech-processbot merged 5 commits into from
May 16, 2023
Merged

Add review rules regarding the owned files #14122

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e0a349b
Add FRAME Coders PR rule
juangirini May 11, 2023
0afdbfe
change regexp rule from `beef` to `beefy`
juangirini May 11, 2023
89669c3
exclude pallet-aura from frame coders rule
juangirini May 12, 2023
fcf836c
Merge remote-tracking branch 'origin/master' into jg/add-frame-coders…
May 12, 2023
24d7b53
Merge remote-tracking branch 'origin/master' into jg/add-frame-coders…
May 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
change regexp rule from beef to beefy
  • Loading branch information
@juangirini
juangirini committed May 11, 2023
commit 0afdbfe8b52f442dc48d37c03975ae2765934460
4 changes: 2 additions & 2 deletions .github/pr-custom-review.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,15 @@ rules:
condition:
include: .*
# excluding files from 'CI team' and 'FRAME coders' rules
exclude: ^\.gitlab-ci\.yml|^scripts/ci/.*|^\.github/.*|^\.config/nextest.toml|^frame/(?!.*(nfts/.*|uniques/.*|babe/.*|grandpa/.*|beef|merkle-mountain-range/.*|contracts/.*|election|nomination-pools/.*|staking/.*))
exclude: ^\.gitlab-ci\.yml|^scripts/ci/.*|^\.github/.*|^\.config/nextest.toml|^frame/(?!.*(nfts/.*|uniques/.*|babe/.*|grandpa/.*|beefy|merkle-mountain-range/.*|contracts/.*|election|nomination-pools/.*|staking/.*))
min_approvals: 2
teams:
- core-devs

- name: FRAME coders
check_type: changed_files
condition:
include: ^frame/(?!.*(nfts/.*|uniques/.*|babe/.*|grandpa/.*|beef|merkle-mountain-range/.*|contracts/.*|election|nomination-pools/.*|staking/.*))
include: ^frame/(?!.*(nfts/.*|uniques/.*|babe/.*|grandpa/.*|beefy|merkle-mountain-range/.*|contracts/.*|election|nomination-pools/.*|staking/.*))
Copy link
Contributor Author

@juangirini juangirini May 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line includes everything under frame expect for those named sub directories, or partially named ones (beef will match beefy and beefy-mmr)
@kianenigma @ggwpez do you think there's more we want to exclude?

Copy link
Member

@ggwpez ggwpez May 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+ aura

Copy link
Contributor Author

@juangirini juangirini May 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ggwpez done

all:
- min_approvals: 2
teams:
Expand Down