Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

frame-system: uniques remove one encode call #14154

Merged
paritytech-processbot merged 3 commits into from
May 16, 2023
Merged

frame-system: uniques remove one encode call #14154

paritytech-processbot merged 3 commits into from
May 16, 2023

Conversation

@bkchr
Copy link
Member

@bkchr bkchr commented May 15, 2023

No description provided.

@bkchr bkchr added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels May 15, 2023
@bkchr bkchr requested a review from a team May 15, 2023 21:15
@ggwpez
Copy link
Member

ggwpez commented May 16, 2023

bot fmt

@command-bot
Copy link

command-bot bot commented May 16, 2023 •
edited
Loading

@ggwpez https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2844002 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 53-361a2261-35dc-4757-ac98-40a6d2e247be to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented May 16, 2023

@ggwpez Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2844002 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2844002/artifacts/download.

@juangirini
Copy link
Contributor

juangirini commented May 16, 2023

bot rebase

@paritytech-processbot
Copy link

paritytech-processbot bot commented May 16, 2023

Rebased

@ggwpez
Copy link
Member

ggwpez commented May 16, 2023

bot merge

@paritytech-processbot paritytech-processbot bot merged commit bbe132e into master May 16, 2023
@paritytech-processbot paritytech-processbot bot deleted the bkchr-improve-uniques branch May 16, 2023 19:56
gpestana pushed a commit that referenced this pull request May 27, 2023
@bkchr @gpestana
frame-system: uniques remove one encode call (#14154)
4f1a1f1 
* frame-system: `uniques` remove one `encode` call

* ".git/.scripts/commands/fmt/fmt.sh"

---------

Co-authored-by: command-bot <>
@kiltbot kiltbot mentioned this pull request Jun 21, 2023
Closed
@kacperzuk-neti kacperzuk-neti mentioned this pull request Jun 23, 2023
Merged
15 tasks
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
@bkchr @nathanwhit
frame-system: uniques remove one encode call (paritytech#14154)
9a935b9 
* frame-system: `uniques` remove one `encode` call

* ".git/.scripts/commands/fmt/fmt.sh"

---------

Co-authored-by: command-bot <>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@KiChjang KiChjang KiChjang approved these changes

@muharem muharem muharem approved these changes

@ggwpez ggwpez ggwpez approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@bkchr @ggwpez @juangirini @KiChjang @muharem