Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Bump proc-macro-warning from 0.3.1 to 0.4.1 #14171

Merged
bkchr merged 4 commits into from
May 29, 2023
Merged

Bump proc-macro-warning from 0.3.1 to 0.4.1 #14171

bkchr merged 4 commits into from
May 29, 2023

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 18, 2023 •
edited by ggwpez
Loading

Bumps proc-macro-warning from 0.3.1 to 0.4.1.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Cumulus companion: paritytech/cumulus#2605

@dependabot
Bump proc-macro-warning from 0.3.1 to 0.4.1
6c07680 
Bumps [proc-macro-warning](https://github.com/ggwpez/proc-macro-warning) from 0.3.1 to 0.4.1.
- [Commits](ggwpez/proc-macro-warning@v0.3.1...v0.4.1)

---
updated-dependencies:
- dependency-name: proc-macro-warning
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from a team May 18, 2023 09:59
@dependabot dependabot bot added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. E2-dependencies Pull requests that update a dependency file. labels May 18, 2023
@KiChjang KiChjang added the D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit label May 18, 2023
@ggwpez
Copy link
Member

ggwpez commented May 18, 2023

Hm looks like the syn crate is locked at 2.0.16 but cumulus is locked at 2.0.15.
It is probably smarter to just use 2.0 in widely-used dependencies, huh?
@sam0x17 i assume this will also affect your crates soon…

@bkchr
Copy link
Member

bkchr commented May 18, 2023

Hm looks like the syn crate is locked at 2.0.16 but cumulus is locked at 2.0.15.

It is not locked, this is just a known bug of the companion system.

@sam0x17
Copy link
Contributor

sam0x17 commented May 19, 2023

Hm looks like the syn crate is locked at 2.0.16 but cumulus is locked at 2.0.15. It is probably smarter to just use 2.0 in widely-used dependencies, huh? @sam0x17 i assume this will also affect your crates soon…

yes, I noticed this when I was attempting to merge the original syn 2.x upgrade PR and companions

@ggwpez
Copy link
Member

ggwpez commented May 19, 2023

So we can ignore the red CI and just merge it?

@bkchr
Copy link
Member

bkchr commented May 19, 2023

So we can ignore the red CI and just merge it?

No we need a companion that is just doing cargo update -p syn

@ggwpez ggwpez mentioned this pull request May 19, 2023
Merged
@ggwpez
Copy link
Member

ggwpez commented May 22, 2023

bot rebase

@paritytech-processbot
Copy link

paritytech-processbot bot commented May 22, 2023

Rebased

@ggwpez
Copy link
Member

ggwpez commented May 28, 2023

bot rebase

@paritytech-processbot
Copy link

paritytech-processbot bot commented May 28, 2023

Rebased

@paritytech-processbot paritytech-processbot bot requested a review from a team May 28, 2023 13:19
@bkchr
Copy link
Member

bkchr commented May 29, 2023

bot rebase

@paritytech-processbot
Copy link

paritytech-processbot bot commented May 29, 2023

Rebased

@bkchr
Copy link
Member

bkchr commented May 29, 2023

bot merge

@paritytech-processbot
Copy link

paritytech-processbot bot commented May 29, 2023

Waiting for commit status.

@paritytech-processbot
Copy link

paritytech-processbot bot commented May 29, 2023

Merge cancelled due to error. Error: Statuses failed for 2f2a972

@bkchr bkchr merged commit f3b12d9 into master May 29, 2023
@bkchr bkchr deleted the dependabot/cargo/proc-macro-warning-0.4.1 branch May 29, 2023 09:45
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
@dependabot @nathanwhit
Bump proc-macro-warning from 0.3.1 to 0.4.1 (paritytech#14171)
c907dce 
Bumps [proc-macro-warning](https://github.com/ggwpez/proc-macro-warning) from 0.3.1 to 0.4.1.
- [Commits](ggwpez/proc-macro-warning@v0.3.1...v0.4.1)

---
updated-dependencies:
- dependency-name: proc-macro-warning
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: parity-processbot <>
@crystalin crystalin mentioned this pull request Oct 20, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@sam0x17 sam0x17 sam0x17 approved these changes

@KiChjang KiChjang KiChjang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit E2-dependencies Pull requests that update a dependency file.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ggwpez @bkchr @sam0x17 @KiChjang