Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Core-Fellowship: use right origin for approve call #14179

Merged
paritytech-processbot merged 1 commit into from
May 19, 2023
Merged

Core-Fellowship: use right origin for approve call #14179

paritytech-processbot merged 1 commit into from
May 19, 2023

Conversation

@muharem
Copy link
Contributor

@muharem muharem commented May 19, 2023 •
edited
Loading

Simple typo fix.
The origin for the approve call should be ApproveOrigin, PromoteOrigin used for the promote call.

@muharem muharem added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels May 19, 2023
@muharem muharem requested a review from a team May 19, 2023 13:56
@ggwpez
Copy link
Member

ggwpez commented May 19, 2023

bot merge

@paritytech-processbot
Copy link

paritytech-processbot bot commented May 19, 2023

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit b938a72 into master May 19, 2023
@paritytech-processbot paritytech-processbot bot deleted the muharem-core-fellowship-origin-typo branch May 19, 2023 16:17
gpestana pushed a commit that referenced this pull request May 27, 2023
@muharem @gpestana
Core-Fellowship: fix origin typo (#14179)
1742221
@kiltbot kiltbot mentioned this pull request Jun 21, 2023
Closed
@kacperzuk-neti kacperzuk-neti mentioned this pull request Jun 23, 2023
Merged
15 tasks
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
@muharem @nathanwhit
Core-Fellowship: fix origin typo (paritytech#14179)
8f95a3a
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@ggwpez ggwpez ggwpez approved these changes

@joepetrowski joepetrowski joepetrowski approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@muharem @ggwpez @joepetrowski