This repository was archived by the owner on Nov 15, 2023. It is now read-only.
add test locking removed when amount is zero #14284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamaharon
reviewed
Jun 1, 2023
Contributor
There was a problem hiding this comment.
Looks good! While you're at it, could you please also check setting reasons to empty (WithdrawReasons::empty()) has the same behavior? See https://github.com/paritytech/substrate/pull/14144/files#diff-0848af5dac3286b1cf09718d38571925e65582729dedacceef836bb2278b612dR856-R859.
liamaharon
added
A0-please_review
liamaharon
added
D3-trivial 🧸
Contributor
Author
|
Hey @liamaharon, thanks for the quick response! Just did the requested changes. |
liamaharon
approved these changes
Jun 1, 2023
Contributor
liamaharon
left a comment
liamaharon
left a comment
There was a problem hiding this comment.
Tabs are preferred for indentation, before merging please fix by running cargo +nightly fmt -p pallet-balances
ggwpez
approved these changes
Jun 2, 2023
Member
|
bot merge |
|
Waiting for commit status. |
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
* add test locking removed when amount is zero * add test set lock with withdraw reasons empty removes lock * fix test set lock with withdraw reasons
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14231
Hey @liamaharon, I've added the test when the amount is zero. Let me know if this is what you have in mind.