Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

[pallet_collective] Enforce prime is a valid member of collective in set_members extrinsic #14354

Merged
paritytech-processbot merged 3 commits into from
Jul 12, 2023
Merged

[pallet_collective] Enforce prime is a valid member of collective in set_members extrinsic #14354

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d7b5f38
Updated set_members extrinsic to enforce prime is valid member of col…
ToufeeqP Jun 12, 2023
d900569
Added additional tests for set_members extrinsic
ToufeeqP Jun 12, 2023
9c61914
applied the code review suggestions
ToufeeqP Jun 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Updated set_members extrinsic to enforce prime is valid member of col… 
…lective
  • Loading branch information
@ToufeeqP
ToufeeqP committed Jun 12, 2023
commit d7b5f38775e343700ae7f8e3562f588da1f8af2a
5 changes: 5 additions & 0 deletions frame/collective/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,6 +345,8 @@ pub mod pallet {
WrongProposalWeight,
/// The given length bound for the proposal was too low.
WrongProposalLength,
/// Prime account is not a member
PrimeAccountNotMember,
}

#[pallet::hooks]
Expand Down Expand Up @@ -416,6 +418,9 @@ pub mod pallet {
old.len(),
);
}
if let Some(p) = prime.clone() {
ensure!(new_members.contains(&p), Error::<T, I>::PrimeAccountNotMember);
}
let mut new_members = new_members;
new_members.sort();
<Self as ChangeMembers<T::AccountId>>::set_members_sorted(&new_members, &old);
Expand Down