Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Contracts add code_len to ContractsInfo #14523

Merged
paritytech-processbot merged 16 commits into from
Jul 14, 2023
Merged

Contracts add code_len to ContractsInfo #14523

paritytech-processbot merged 16 commits into from
Jul 14, 2023

Conversation

@pgherveou
Copy link
Contributor

@pgherveou pgherveou commented Jul 6, 2023 •
edited
Loading

fix #14507

@pgherveou pgherveou changed the base branch from master to pg/rename_v9_to_v09 July 6, 2023 13:04
pgherveou
pgherveou commented Jul 6, 2023
View reviewed changes
pgherveou
pgherveou commented Jul 6, 2023
View reviewed changes
@pgherveou pgherveou mentioned this pull request Jul 7, 2023
Closed
@pgherveou pgherveou marked this pull request as ready for review July 7, 2023 10:22
@pgherveou pgherveou requested a review from athei as a code owner July 7, 2023 10:22
@pgherveou pgherveou requested a review from a team July 7, 2023 10:22
@pgherveou pgherveou added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Jul 7, 2023
@pgherveou pgherveou force-pushed the pg/rename_v9_to_v09 branch from dcaa08d to 42d1823 Compare July 7, 2023 11:57
@pgherveou
Copy link
Contributor Author

pgherveou commented Jul 7, 2023

oups looks like I messed up the base branch, fixing it now

@pgherveou pgherveou changed the base branch from pg/rename_v9_to_v09 to pg/delegate_deposit July 7, 2023 12:22
@athei athei requested a review from juangirini July 7, 2023 13:13
@pgherveou pgherveou changed the base branch from pg/delegate_deposit to master July 10, 2023 09:48
@pgherveou
Copy link
Contributor Author

pgherveou commented Jul 10, 2023

Need to fix gas_estimation_call_runtime test

pgherveou
pgherveou commented Jul 10, 2023
View reviewed changes
@pgherveou pgherveou requested a review from athei July 10, 2023 15:47
@pgherveou
Copy link
Contributor Author

pgherveou commented Jul 10, 2023

@athei did some quick update and forced push to rebase on master 🙈
I fixed a test that I think was not super correct gas_estimation_call_runtime and took the opportunity to move the tests to a test folder so we can break it up into smaller chunks later

Tests are green would be great to merge that soon if we want to use the v12 migration step

juangirini
juangirini approved these changes Jul 12, 2023
View reviewed changes
athei
athei approved these changes Jul 14, 2023
View reviewed changes
@pgherveou
Copy link
Contributor Author

pgherveou commented Jul 14, 2023

bot merge

@paritytech-processbot
Copy link

paritytech-processbot bot commented Jul 14, 2023

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit 74ae051 into master Jul 14, 2023
@paritytech-processbot paritytech-processbot bot deleted the pg/add_code_len branch July 14, 2023 12:49
@pgherveou pgherveou mentioned this pull request Jul 14, 2023
Merged
pgherveou added a commit that referenced this pull request Jul 14, 2023
@pgherveou
Contracts add code_len to ContractsInfo (#14523)
bf6fce6 
* add code_len to v12

* fix

* Update frame/contracts/src/wasm/mod.rs

* fix

* fixes

* rm test

* add test back

* fix

* update test

* Fix comments

* fix build

* del

* fix clippy

* fix

* re-rename
coderobe pushed a commit that referenced this pull request Jul 14, 2023
@pgherveou @coderobe
Contracts add code_len to ContractsInfo (#14523)
efe6615 
* add code_len to v12

* fix

* Update frame/contracts/src/wasm/mod.rs

* fix

* fixes

* rm test

* add test back

* fix

* update test

* Fix comments

* fix build

* del

* fix clippy

* fix

* re-rename
@coderobe coderobe mentioned this pull request Jul 14, 2023
Merged
coderobe added a commit that referenced this pull request Jul 14, 2023
@coderobe @pgherveou
Contracts add code_len to ContractsInfo (#14523) (#14580)
6d28d2e 
* add code_len to v12

* fix

* Update frame/contracts/src/wasm/mod.rs

* fix

* fixes

* rm test

* add test back

* fix

* update test

* Fix comments

* fix build

* del

* fix clippy

* fix

* re-rename

Co-authored-by: PG Herveou <[email protected]>
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
@pgherveou @nathanwhit
Contracts add code_len to ContractsInfo (paritytech#14523)
6d56cae 
* add code_len to v12

* fix

* Update frame/contracts/src/wasm/mod.rs

* fix

* fixes

* rm test

* add test back

* fix

* update test

* Fix comments

* fix build

* del

* fix clippy

* fix

* re-rename
Ank4n pushed a commit that referenced this pull request Jul 22, 2023
@pgherveou @Ank4n
Contracts add code_len to ContractsInfo (#14523)
3e97640 
* add code_len to v12

* fix

* Update frame/contracts/src/wasm/mod.rs

* fix

* fixes

* rm test

* add test back

* fix

* update test

* Fix comments

* fix build

* del

* fix clippy

* fix

* re-rename
@pgherveou pgherveou mentioned this pull request Jul 26, 2023
Merged
@TorstenStueber TorstenStueber mentioned this pull request Feb 26, 2024
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@juangirini juangirini juangirini approved these changes

@athei athei athei approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

contracts: Store the code size in CodeInfo

4 participants

@pgherveou @athei @juangirini