Transaction Fee Module #1648

xlc · 2019-02-01T07:50:15Z

This introduces ChargeFee and TransferAsset trait which reduces the coupling between balances module and other modules.

A new Fees module is added to handle all transaction fee related work. Later it can be used to handle transaction fee distribution. It also provide a unified Charged even to simplify client side transaction fee listening.

The new module and traits should be able to handle various kinds of token implementations (current balances module, multi token module, UTXO module).

Close #1515
Relates to #1514
May conflicts to #1641

gavofyork · 2019-02-01T09:06:36Z

Looks like an overall good direction!

pepyakin

This looks good! It is difficult for me to see though how the implementation for UTXO chains would look like.

srml/balances/src/lib.rs

srml/fees/src/lib.rs

srml/balances/src/lib.rs

xlc · 2019-02-04T22:42:06Z

@pepyakin It is hard to be confident this will actually work with UTXO implementation without actually integrate with it, but here are my thoughts:

The UTXO module will implement TransferAsset trait and it won't do the actual transfer, but instead making some checks that this transfer is specified in the transaction. e.g. call transfer from A to B with amount of 100, will check the there is an output for B with remaining amount > 100 and reduce the remaining amount for this output by 100. The transfer_from method or transfer from use account to system account method, will check the amount is less than remaining amount of tx fee in this tx (i.e. total input - total output).
Then the rewards part (which should be a new trait which I don't want to include in this PR to limit its scope) will create a new coinbase output for each validators for them to get their rewards. The UTXO module could potentially merge multiple coinbase outputs (one from tx fee rewards, one from block validation rewards) into one to reduce storage usage.

node-template/runtime/Cargo.toml

node-template/runtime/src/lib.rs

srml/balances/src/lib.rs

srml/fees/src/lib.rs

xlc · 2019-02-12T03:48:39Z

@shawntabrizi @pepyakin This is ready for review

srml/contract/src/lib.rs

shawntabrizi

Looks good to me :)

srml/fees/src/lib.rs

bkchr

Just some nitpicks.

srml/fees/src/lib.rs

srml/fees/src/mock.rs

srml/fees/src/lib.rs

srml/fees/src/tests.rs

xlc · 2019-02-14T21:36:13Z

@bkchr can you have a look again and maybe merge it? This is ready and we would like to have this included to unblock us from next task, which is refactor balances and contract module to use this to charge fee. This then will make it possible to block explorer to easily fetch the total transaction fee of a transfer and then produce an accurate balance statement easily.

bkchr · 2019-02-14T22:51:43Z

Will take a last look tomorrow morning and merge then probably.

* wip * Split bytes fee charging and charging by amount into different traits. * Move to edition 2018. * Implemented charge fee traits for fees module. * Implemented 'on_finalise' for fee module. * Updated fees finalize impl. * Renaming and documentation update. * Added overflow & underflow check for fee calculation. * Added mock and unit tests for fee module. * More unit tests for fees module. * Fixed srml-executive unit tests. * Remove transaction base/bytes fee from balances module, fix unit tests. * fix compile error * Fixed unit test. * Minor fixes. * Bump spec version. * Bump spec version. * Updated fees module and runtime wasm. * Fees module code style improvement; updated runtime wasm. * Bump spec and impl version.

xlc and others added 4 commits January 31, 2019 13:19

wip

85a1953

Split bytes fee charging and charging by amount into different traits.

274801f

Move to edition 2018.

eccd12c

Implemented charge fee traits for fees module.

81a3929

gavofyork approved these changes Feb 1, 2019

View reviewed changes

gavofyork requested review from pepyakin and shawntabrizi February 1, 2019 09:01

gavofyork added the A0-please_review Pull request needs code review. label Feb 1, 2019

gavofyork added A3-in_progress Pull request is in progress. No review needed at this stage. and removed A0-please_review Pull request needs code review. labels Feb 1, 2019

pepyakin reviewed Feb 1, 2019

View reviewed changes

shaunxw added 2 commits February 4, 2019 14:54

Implemented 'on_finalise' for fee module.

5923d01

Merge branch 'master' into fee

dd504f8

shawntabrizi reviewed Feb 4, 2019

View reviewed changes

shaunxw added 4 commits February 7, 2019 11:51

Updated fees finalize impl.

50f2cd5

Renaming and documentation update.

d9b951a

Added overflow & underflow check for fee calculation.

02f6358

Added mock and unit tests for fee module.

25cbd29

shaunxw force-pushed the fee branch from 0cd5634 to 25cbd29 Compare February 7, 2019 04:22

shaunxw and others added 6 commits February 8, 2019 15:53

More unit tests for fees module.

13c31be

Fixed srml-executive unit tests.

df8d4d1

Merge branch 'master' into fee

f4ef7b5

Remove transaction base/bytes fee from balances module, fix unit tests.

ba58808

Merge remote-tracking branch 'upstream/master' into fee

b12405a

fix compile error

b23cd67

devops-parity added the B2-breaksapi label Feb 11, 2019

Merge branch 'fee' of github.com:xlc/substrate into fee

544e18c

xlc commented Feb 12, 2019

View reviewed changes

shaunxw added 5 commits February 12, 2019 14:12

Fixed unit test.

670f431

Minor fixes.

a9a948a

Bump spec version.

3b9faa4

Merge branch 'master' into fee

b420972

Bump spec version.

857d3dc

xlc changed the title ~~Transaction Fee Module (WIP)~~ Transaction Fee Module Feb 12, 2019

gui1117 reviewed Feb 12, 2019

View reviewed changes

srml/contract/src/lib.rs Show resolved Hide resolved

shawntabrizi approved these changes Feb 12, 2019

View reviewed changes

srml/fees/src/lib.rs Outdated Show resolved Hide resolved

srml/fees/src/lib.rs Outdated Show resolved Hide resolved

Updated fees module and runtime wasm.

d84c199

bkchr added the A3-needsresolving label Feb 13, 2019

bkchr reviewed Feb 13, 2019

View reviewed changes

shaunxw added 4 commits February 13, 2019 23:55

Fees module code style improvement; updated runtime wasm.

4908fbb

Merge branch 'master' into fee

a0af48d

Bump spec and impl version.

70a14dc

Merge branch 'master' into fee

4e6c4f8

bkchr approved these changes Feb 15, 2019

View reviewed changes

bkchr merged commit 14ee64c into paritytech:master Feb 15, 2019

xlc deleted the fee branch February 15, 2019 10:27

shaunxw mentioned this pull request Feb 18, 2019

Use ChargeFee in balances and contract modules. #1815

Closed

shawntabrizi mentioned this pull request Mar 9, 2019

Fees Module polkadot-developers/substrate-developer-hub.github.io#31

Closed

7 tasks

arvinxx mentioned this pull request Sep 21, 2019

第二周课程答疑整理 SubstrateOrg/Team1#15

Closed

This was referenced Oct 25, 2021

Bump tracing-subscriber from 0.2.19 to 0.3.0 GeekCash/substrate#6

Closed

Bump tracing-subscriber from 0.2.19 to 0.3.1 GeekCash/substrate#7

Closed

dependabot bot mentioned this pull request Nov 5, 2021

Bump tracing-subscriber from 0.2.25 to 0.3.1 #10199

Closed

xlc mentioned this pull request Sep 27, 2022

Member Request polkadot-fellows/seeding#7

Merged

Transaction Fee Module #1648

Transaction Fee Module #1648

Uh oh!

Conversation

xlc commented Feb 1, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gavofyork commented Feb 1, 2019

Uh oh!

pepyakin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

xlc commented Feb 4, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

xlc commented Feb 12, 2019

Uh oh!

Uh oh!

shawntabrizi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

bkchr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

xlc commented Feb 14, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bkchr commented Feb 14, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

xlc commented Feb 1, 2019 •

edited

Loading

xlc commented Feb 14, 2019 •

edited

Loading