-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Documentation for assets module #1945
Conversation
|
@bkchr I've pushed commits to address your review comments. |
|
@ltfschoen based on the new discussion progress the file should be changed to .md |
|
@ltfschoen Also the template has changed a bit, and I think this does not quite reflect that |
|
@kianenigma @shawntabrizi @xlc @bkchr I've pushed a commit to address all comments. Run |
Co-Authored-By: ltfschoen <[email protected]>
Co-Authored-By: ltfschoen <[email protected]>
Co-Authored-By: ltfschoen <[email protected]>
Co-Authored-By: ltfschoen <[email protected]>
Co-Authored-By: ltfschoen <[email protected]>
…as per comment
|
@joepetrowski I've addressed your comments and the indentation. This comment is outstanding: #1945 (comment) |
|
Changes LGTM, should get resolution on the "goals" section and approval from code author before merging. |
|
Updated links, style, shortened a few things to match other modules. Should consider removing the |
|
@bkchr who would be most appropriate to get resolution on the "goals" section, and who would be the most appropriate code author to provide approval, as mentioned here #1945 (comment) |
|
@ltfschoen this documentation is not following the standard like the others. Then there are code example that will not be tested by rustdoc. |
|
This is kind of pointless test code as it doesn't demonstrate how to use the three transaction functions. But I guess there's a bit more detail than before. I removed the obviously pointless bits of code (getters that didn't actually get) and will merge. |
* WIP - SRML Assets Module README * docs: Tweaks for consistency * docs: Add missing newline * review-fix: Remove non-SRML trait dependencies * review-fix: Replace const with let * review-fix: Remove use of compact in signature * review-fix: Change const to let since cannot use result of function call * fix: Add backticks around type and mention type it derives from * review-fix: Update variable names since changed to lowercase since using let * fix: Change type to bold instead of code * review-fix: Update Asset module * refactor: Consistent bullet points. Remove whitespace between items * review-fix: Remove useless blah * review-fix: Remove Storage Items * review-fix: Remove Types * review-fix: Remove duplicate instructions * Update srml/assets/src/lib.rs Co-Authored-By: ltfschoen <[email protected]> * Update srml/assets/src/lib.rs Co-Authored-By: ltfschoen <[email protected]> * Update srml/assets/src/lib.rs Co-Authored-By: ltfschoen <[email protected]> * Update srml/assets/src/lib.rs Co-Authored-By: ltfschoen <[email protected]> * Update srml/assets/src/lib.rs Co-Authored-By: ltfschoen <[email protected]> * Update srml/assets/src/lib.rs Co-Authored-By: ltfschoen <[email protected]> * Update srml/assets/src/lib.rs Co-Authored-By: ltfschoen <[email protected]> * Update srml/assets/src/lib.rs Co-Authored-By: ltfschoen <[email protected]> * Update srml/assets/src/lib.rs Co-Authored-By: ltfschoen <[email protected]> * Update srml/assets/src/lib.rs Co-Authored-By: ltfschoen <[email protected]> * Update srml/assets/src/lib.rs Co-Authored-By: ltfschoen <[email protected]> * Update srml/assets/src/lib.rs Co-Authored-By: ltfschoen <[email protected]> * Update srml/assets/src/lib.rs Co-Authored-By: ltfschoen <[email protected]> * Update srml/assets/src/lib.rs Co-Authored-By: ltfschoen <[email protected]> * Update srml/assets/src/lib.rs Co-Authored-By: ltfschoen <[email protected]> * review-fix: Remove since will be replaced after macro expansion paritytech#2068 as per comment * review-fix: Move Goals within overview * fix: Fix indentation * style and a few minor changes * remove Events * capitalization * docs: Reword the Goals to remove mention of cold wallets based on discussion with Joe * Wording * Update lib.rs * Update lib.rs * Update lib.rs
Relates to polkadot-developers/substrate-developer-hub.github.io#22