This repository was archived by the owner on Nov 15, 2023. It is now read-only.
SRML Executive Documentation #2144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
1 similar comment
|
It looks like @joepetrowski signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
| //! | ||
| //! The executive module provides the following implementations: | ||
| //! | ||
| //! - `ExecuteBlock`: Trait that can be used to execute a block. |
Contributor
There was a problem hiding this comment.
Do we need this section? I think we decided not to mention implementation details in this section of the docs.
Contributor
Author
There was a problem hiding this comment.
It's not really describing the logic. I see it as, "avoid coupling with this module if these traits have what you need." Since executive in particular doesn't have a decl_module! or impl Module, then maybe it's not necessary at all.
bkchr
approved these changes
Apr 12, 2019
cmichi
pushed a commit
that referenced
this pull request
Apr 13, 2019
* executive docs first draft * link updates * gautam update * capitalization * typo fix
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: polkadot-developers/substrate-developer-hub.github.io#30
Please review, I understand the high-level roles of executive but see that a lot happens in macro expansion and am not certain in my knowledge.