Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Add warning when using default protocol ID #2234

Merged
bkchr merged 2 commits into from
Apr 9, 2019
Merged

Add warning when using default protocol ID #2234

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d2ef67
Add warning when using default protocol ID
tomaka Apr 8, 2019
5065ad1
Update core/service/src/lib.rs
tomaka Apr 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion core/service/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,14 @@ impl<Components: components::Components> Service<Components> {
};

let protocol_id = {
let protocol_id_full = config.chain_spec.protocol_id().unwrap_or(DEFAULT_PROTOCOL_ID).as_bytes();
let protocol_id_full = match config.chain_spec.protocol_id() {
Some(pid) => pid,
None => {
warn!("Using default protocol ID {:?} because none is configured in the \
chain specs", DEFAULT_PROTOCOL_ID);
DEFAULT_PROTOCOL_ID
}
}.as_bytes();
let mut protocol_id = network::ProtocolId::default();
if protocol_id_full.len() > protocol_id.len() {
warn!("Protocol ID truncated to {} chars", protocol_id.len());
Expand Down